The default bug view has changed. See this FAQ.

Direct users to the Notification Center settings to disable badge of Dock Icon

RESOLVED FIXED in Thunderbird 42.0

Status

Thunderbird
Preferences
--
trivial
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Javi Rueda, Assigned: Javi Rueda)

Tracking

Trunk
Thunderbird 42.0
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

76.45 KB, image/png
Details
1.95 KB, patch
Magnus Melin
: review+
bwinton
: ui-review+
Details | Diff | Splinter Review
(Assignee)

Description

2 years ago
That is one of the usual requests from users, the ability to disable the badge on the Dock icon on OS X.

Although we could implement a way to really stop showing it, OS X provides a standard way to do that same thing. In fact, if we really were to implement that setting, it woyld be not respected, as the badge is managed by the system itself.

A much better way is just to indicate the user where that setting must be changed, as it seems it is not very well known.
(Assignee)

Comment 1

2 years ago
Created attachment 8638289 [details]
Proposed caption

Hi Blake.

I have added a caption that directs users to the Notification panel on the System Preferences dialog box.

I am not an English as a first language speaker, so may be some rewording could be needed.

Could you please review it? Thank you.
Attachment #8638289 - Flags: ui-review?(bwinton)
Comment on attachment 8638289 [details]
Proposed caption

I think making it more of a sentence would fit in better with the rest of Thunderbird’s text.  How about “You can disable the badge on the Notifications pane of System Preferences.”?  (I also used the official Apple names for the various pieces, there, too. :)  And just to double-check, this text will only show up when you’re on a Mac, right?

(I'm setting it to ui-r-, not because I think it's bad, but just to indicate that I have some open questions.)
Attachment #8638289 - Flags: ui-review?(bwinton) → ui-review-
(Assignee)

Comment 3

2 years ago
(In reply to Blake Winton (:bwinton) from comment #2)
> Comment on attachment 8638289 [details]
> Proposed caption
> 
> I think making it more of a sentence would fit in better with the rest of
> Thunderbird’s text.  How about “You can disable the badge on the
> Notifications pane of System Preferences.”?  (I also used the official Apple
> names for the various pieces, there, too. :)  And just to double-check, this
> text will only show up when you’re on a Mac, right?
> 

Ok. I am going to replace my proposed text with yours, as it is much better.

Also, about your question, both dockoptions.xul and corresponding .dtd is only added to the package, which user will download, when source code is being built for OS X: https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=601263&attachment=8384723 as can be seen on jar.mn files.
Perfect!  Feel free to ui-r? me on the patch, and I'll try to give it a quick ui-r+.  :)
(Assignee)

Comment 5

2 years ago
Created attachment 8638607 [details]
Corrected caption
Attachment #8638289 - Attachment is obsolete: true
(Assignee)

Comment 6

2 years ago
Created attachment 8638609 [details] [diff] [review]
bug-1187158.patch

Patch corresponding to the screenshoot (attachment 8638607 [details]).

Files modified had been previously reviewed by :standard8, so I am assuming he is the best guess here also.

Mark, could you take a look on this patch, please? Thank you.
Attachment #8638609 - Flags: ui-review?(bwinton)
Attachment #8638609 - Flags: review?(standard8)
Comment on attachment 8638609 [details] [diff] [review]
bug-1187158.patch

:)
Attachment #8638609 - Flags: ui-review?(bwinton) → ui-review+
Comment on attachment 8638609 [details] [diff] [review]
bug-1187158.patch

Sorry, I'm not generally doing Thunderbird reviews these days.
Attachment #8638609 - Flags: review?(standard8) → review?(mkmelin+mozilla)

Comment 9

2 years ago
Comment on attachment 8638609 [details] [diff] [review]
bug-1187158.patch

Review of attachment 8638609 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, Javi! r=mkmelin
Attachment #8638609 - Flags: review?(mkmelin+mozilla) → review+
(Assignee)

Comment 10

2 years ago
Thank you for the review, Magnus.
Keywords: checkin-needed

Comment 11

2 years ago
url:        https://hg.mozilla.org/comm-central/rev/8160e3fc67ae54531c66265bc4872c002abfb7e9
changeset:  8160e3fc67ae54531c66265bc4872c002abfb7e9
user:       Javier Rueda <leofigueres@yahoo.com>
date:       Fri Jul 24 10:06:00 2015 +0200
description:
Bug 1187158 - Direct users to the Notification Center settings to disable badge of Dock Icon. r=mkmelin, ui-r=bwinton

Updated

2 years ago
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 42.0
You need to log in before you can comment on or make changes to this bug.