Closed Bug 1187165 Opened 4 years ago Closed 4 years ago

Use channel->ascynOpen2 in dom/base/ImportManager.cpp

Categories

(Core :: DOM: Security, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: ckerschb, Assigned: ckerschb)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → mozilla
Blocks: 1182535
Comment on attachment 8643950 [details] [diff] [review]
bug_1187165_asyncopen2_importmanager.patch

Review of attachment 8643950 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/ImportManager.cpp
@@ +466,3 @@
>  
> +  nsCOMPtr<nsILoadGroup> loadGroup =
> +    mImportParent->MasterDocument()->GetDocumentLoadGroup();

I'd get rid of this temporary.

@@ +471,2 @@
>    nsCOMPtr<nsIChannel> channel;
>    rv = NS_NewChannel(getter_AddRefs(channel),

just do

nsresult rv = ...;
Attachment #8643950 - Flags: review?(jonas) → review+
url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/12742043d2a70d926a290828e04688c4c3473d4c
changeset:  12742043d2a70d926a290828e04688c4c3473d4c
user:       Christoph Kerschbaumer <mozilla@christophkerschbaumer.com>
date:       Mon Aug 10 10:25:20 2015 -0700
description:
Bug 1187165 -  Use channel->ascynOpen2 in dom/base/ImportManager (r=sicking)
https://hg.mozilla.org/mozilla-central/rev/12742043d2a7
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.