bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Char16 wrapper for VS2015 doesn't work with external NS_ConvertUTF16toUTF8

RESOLVED FIXED in Firefox 42

Status

()

Core
XPCOM
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: xidorn, Assigned: xidorn)

Tracking

Trunk
mozilla42
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
The Char16 pointer wrapper for VS2015 doesn't work with the NS_ConvertUTF16toUTF8 in external String API. It causes the following compile error:
> central/browser/components/shell/nsWindowsShellService.cpp(397): error C2440: '<function-style-cast>': cannot convert from 'LPCWSTR' to 'NS_ConvertUTF16toUTF8_external'
> central/browser/components/shell/nsWindowsShellService.cpp(397): note: Source or target has incomplete type
(Assignee)

Comment 1

3 years ago
Created attachment 8638348 [details] [diff] [review]
patch
Attachment #8638348 - Flags: review?(nfroyd)
(Assignee)

Updated

3 years ago
Assignee: nobody → quanxunzhen
Attachment #8638348 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/ecfe46601d7f
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox42: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42

Updated

3 years ago
Depends on: 1188431
You need to log in before you can comment on or make changes to this bug.