Implement a thread-safe observer to publish events across threads

RESOLVED FIXED in Firefox 42

Status

()

Core
Audio/Video: Playback
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

unspecified
mozilla42
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
We will implement the observer pattern with a generic and thread-safe class. It will be used by the MediaQueue to publish push/pop/finish events across threads to its listeners.
(Assignee)

Updated

3 years ago
Assignee: nobody → jwwang
Component: Audio/Video → Audio/Video: Playback
(Assignee)

Updated

3 years ago
Blocks: 1188257
(Assignee)

Comment 4

3 years ago
Created attachment 8642905 [details]
MozReview Request: Bug 1187214. Part 1 - Implement MediaEventSource.

Bug 1187214. Part 1 - Implement MediaEventSource.
Attachment #8642905 - Flags: review?(kinetik)
(Assignee)

Comment 5

3 years ago
Created attachment 8642906 [details]
MozReview Request: Bug 1187214. Part 2 - add test cases for MediaEventSource.

Bug 1187214. Part 2 - add test cases for MediaEventSource.
Attachment #8642906 - Flags: review?(kinetik)
(Assignee)

Comment 6

3 years ago
It is worth noting that each listener can be disconnected independently which gives more flexibility than MediaQueue::ClearListeners().
(Assignee)

Comment 7

3 years ago
The usage will be in bug 1188257.
(Assignee)

Updated

3 years ago
Blocks: 1189624
Comment on attachment 8642906 [details]
MozReview Request: Bug 1187214. Part 2 - add test cases for MediaEventSource.

https://reviewboard.mozilla.org/r/14981/#review13515

Ship It!
Attachment #8642906 - Flags: review?(kinetik) → review+
Comment on attachment 8642905 [details]
MozReview Request: Bug 1187214. Part 1 - Implement MediaEventSource.

https://reviewboard.mozilla.org/r/14979/#review13517

Ship It!

::: dom/media/MediaEventSource.h:364
(Diff revision 1)
> +    this->NotifyInternal(true /* dummp */);

Typo in comment.
Attachment #8642905 - Flags: review?(kinetik) → review+
(Assignee)

Comment 10

3 years ago
Thanks for the review!
https://hg.mozilla.org/mozilla-central/rev/c0a6f89391ee
https://hg.mozilla.org/mozilla-central/rev/8caf2b95b275
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.