1187214 - Implement a thread-safe observer to publish events across threads

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

We will implement the observer pattern with a generic and thread-safe class. It will be used by the MediaQueue to publish push/pop/finish events across threads to its listeners.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=23e6a45100a6

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Try again. https://treeherder.mozilla.org/#/jobs?repo=try&revision=15fcc853705b

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Finally it is green. https://treeherder.mozilla.org/#/jobs?repo=try&revision=992ca7f6ee87

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1187214. Part 1 - Implement MediaEventSource.

Bug 1187214. Part 1 - Implement MediaEventSource.

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1187214. Part 2 - add test cases for MediaEventSource.

Bug 1187214. Part 2 - add test cases for MediaEventSource.

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

It is worth noting that each listener can be disconnected independently which gives more flexibility than MediaQueue::ClearListeners().

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

The usage will be in bug 1188257.

Comment 8

[Matthew Gregan [:kinetik]]

Comment on attachment 8642906 [details]
MozReview Request: Bug 1187214. Part 2 - add test cases for MediaEventSource.

https://reviewboard.mozilla.org/r/14981/#review13515

Ship It!

Comment 9

[Matthew Gregan [:kinetik]]

Comment on attachment 8642905 [details]
MozReview Request: Bug 1187214. Part 1 - Implement MediaEventSource.

https://reviewboard.mozilla.org/r/14979/#review13517

Ship It!

::: dom/media/MediaEventSource.h:364
(Diff revision 1)
> +    this->NotifyInternal(true /* dummp */);

Typo in comment.

Comment 10

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c0a6f89391ee
https://hg.mozilla.org/integration/mozilla-inbound/rev/8caf2b95b275

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c0a6f89391ee
https://hg.mozilla.org/mozilla-central/rev/8caf2b95b275