1187219 - Remove _visuallySelected, _logicallySelected from tabbox.xml, avoid code duplication with tabbrowser.xml

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8638390 [details] [diff] [review]
patch

Review of attachment 8638390 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, I thinks this makes much more sense. Thanks Dao!

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/1efbd6874bfb

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Something in this push made browser_dragdrop.js try to hit the network on OSX 10.10. Backed out.
https://treeherder.mozilla.org/logviewer.html#?job_id=3978258&repo=fx-team
https://treeherder.mozilla.org/logviewer.html#?job_id=3978254&repo=fx-team
https://treeherder.mozilla.org/logviewer.html#?job_id=3978108&repo=fx-team

https://hg.mozilla.org/integration/fx-team/rev/8a62423b8343

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/0a51403a45e9

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0a51403a45e9

Comment 6

[tabmix.onemen]

This change break users of tabbox.xml since the rules in tabbox.css using "visuallyselected"

Comment 7

[Dão Gottwald [:dao]]

(In reply to tabmix.onemen from comment #6)
> This change break users of tabbox.xml since the rules in tabbox.css using
> "visuallyselected"

Ouch! Could you please file a new bug on this?

Comment 8

[Dão Gottwald [:dao]]

Never mind, I filed bug 1190209.