Closed
Bug 1187219
Opened 9 years ago
Closed 9 years ago
Remove _visuallySelected, _logicallySelected from tabbox.xml, avoid code duplication with tabbrowser.xml
Categories
(Toolkit :: UI Widgets, defect)
Toolkit
UI Widgets
Tracking
()
RESOLVED
FIXED
mozilla42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file)
5.85 KB,
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8638390 -
Flags: review?(mconley)
Comment 1•9 years ago
|
||
Comment on attachment 8638390 [details] [diff] [review] patch Review of attachment 8638390 [details] [diff] [review]: ----------------------------------------------------------------- Yes, I thinks this makes much more sense. Thanks Dao!
Attachment #8638390 -
Flags: review?(mconley) → review+
Comment 3•9 years ago
|
||
Something in this push made browser_dragdrop.js try to hit the network on OSX 10.10. Backed out. https://treeherder.mozilla.org/logviewer.html#?job_id=3978258&repo=fx-team https://treeherder.mozilla.org/logviewer.html#?job_id=3978254&repo=fx-team https://treeherder.mozilla.org/logviewer.html#?job_id=3978108&repo=fx-team https://hg.mozilla.org/integration/fx-team/rev/8a62423b8343
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0a51403a45e9
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Comment 6•9 years ago
|
||
This change break users of tabbox.xml since the rules in tabbox.css using "visuallyselected"
Assignee | ||
Comment 7•9 years ago
|
||
(In reply to tabmix.onemen from comment #6) > This change break users of tabbox.xml since the rules in tabbox.css using > "visuallyselected" Ouch! Could you please file a new bug on this?
You need to log in
before you can comment on or make changes to this bug.
Description
•