Closed Bug 1187219 Opened 5 years ago Closed 5 years ago

Remove _visuallySelected, _logicallySelected from tabbox.xml, avoid code duplication with tabbrowser.xml

Categories

(Toolkit :: XUL Widgets, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
No description provided.
Attachment #8638390 - Flags: review?(mconley)
Comment on attachment 8638390 [details] [diff] [review]
patch

Review of attachment 8638390 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, I thinks this makes much more sense. Thanks Dao!
Attachment #8638390 - Flags: review?(mconley) → review+
https://hg.mozilla.org/mozilla-central/rev/0a51403a45e9
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
This change break users of tabbox.xml since the rules in tabbox.css using "visuallyselected"
(In reply to tabmix.onemen from comment #6)
> This change break users of tabbox.xml since the rules in tabbox.css using
> "visuallyselected"

Ouch! Could you please file a new bug on this?
Never mind, I filed bug 1190209.
Depends on: 1190209
You need to log in before you can comment on or make changes to this bug.