Closed Bug 1187230 Opened 5 years ago Closed 4 years ago

Move Bluetooth's daemon runnables to ipc/hal

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(firefox42 fixed)

RESOLVED FIXED
FxOS-S4 (07Aug)
Tracking Status
firefox42 --- fixed

People

(Reporter: tzimmermann, Assigned: tzimmermann)

References

Details

Attachments

(3 files, 2 obsolete files)

The runnables classes for Bluetooth's daemon can be used by other daemons as well and thus should be moved to hal/ipc
No big changes here; just moving code around.
Comment on attachment 8638427 [details] [diff] [review]
[02] Bug 1187230: Convert Bluetooth to use daemon runnables

Review of attachment 8638427 [details] [diff] [review]:
-----------------------------------------------------------------

I expected that only replace class names here :) Thanks.
Attachment #8638427 - Flags: review?(shuang) → review+
Changes since v1:

  - small style fix: GATT notification runnables explicitly use mozilla::ipc in typedef
Attachment #8638427 - Attachment is obsolete: true
Attachment #8638513 - Flags: review+
sorry had to revert this change for bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=2374347&repo=b2g-inbound
Flags: needinfo?(tzimmermann)
I built the patchset for aries-l and didn't get this error. :(
Flags: needinfo?(tzimmermann)
Changes since v1:

  - shift result of |NS_DispatchToMainThread| into |unused|
Attachment #8638426 - Attachment is obsolete: true
Attachment #8639182 - Flags: review+
(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #10)
> I built the patchset for aries-l and didn't get this error. :(

I guess '-Werror' option is disabled.
You need to log in before you can comment on or make changes to this bug.