1187249 - Move Bluetooth IPC helpers to ipc/hal

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

The files BluetoothDaemonHelpers.{cpp,h} contain helper functions for packing and unpacking IPC message. Many of these functions are unrelated to Bluetooth. They should be moved to ipc/hal.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1187249: Move |DaemonSocketPDUHeader| to hal/ipc

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [02] Bug 1183249: Move PDU helper functions to ipc/hal

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [03] Bug 1187249: Move Bluetooth init operators to ipc/hal

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [04] Bug 1187249: Cleanup |BluetoothInterfaceHelpers.{cpp,h}|

A small final cleanup, since I'm working on it anyway.

Comment 5

[Thomas Zimmermann [:tzimmermann] [:tdz]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=03f1735958f8

Comment 6

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Comment on attachment 8639252 [details] [diff] [review]
[01] Bug 1187249: Move |DaemonSocketPDUHeader| to hal/ipc

Review of attachment 8639252 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not sure I have permission to review, but it looks good to me.

Comment 7

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

(In reply to Shawn Huang [:shawnjohnjr] from comment #6)
> Comment on attachment 8639252 [details] [diff] [review]
> [01] Bug 1187249: Move |DaemonSocketPDUHeader| to hal/ipc
> 
> Review of attachment 8639252 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I'm not sure I have permission to review, but it looks good to me.

I mean that code under ipc folder.

Comment 8

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Should be OK. It's the code that was in Bluetooth with some renames and small adjustments. And there is a lack of potential reviewers for IPC anyway.

Comment 9

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Comment on attachment 8639253 [details] [diff] [review]
[02] Bug 1183249: Move PDU helper functions to ipc/hal

Review of attachment 8639253 [details] [diff] [review]:
-----------------------------------------------------------------

::: ipc/hal/DaemonSocketPDUHelpers.h
@@ +41,5 @@
> +// byte arrays. Gecko often uses more complex data types, such as
> +// enumators or stuctures. Conversion functions convert between
> +// primitive data and internal Gecko's data types during a PDU's
> +// packing and unpacking.
> +//

Why not use multiline comment style?

Comment 10

[Thomas Zimmermann [:tzimmermann] [:tdz]]

> 
> Why not use multiline comment style?

There's no specific reason. All the other 'block headlines' already use C++ comments, so I just continued this style for consistency.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/6275657f07e4
https://hg.mozilla.org/integration/b2g-inbound/rev/f42f6d744917
https://hg.mozilla.org/integration/b2g-inbound/rev/845d0438fece

Comment 12

[Thomas Zimmermann [:tzimmermann] [:tdz]]

https://hg.mozilla.org/integration/b2g-inbound/rev/f82cbe9aaa13

Comment 13

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Thanks Shawn!

https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=845d0438fece

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6275657f07e4
https://hg.mozilla.org/mozilla-central/rev/f42f6d744917
https://hg.mozilla.org/mozilla-central/rev/845d0438fece