All users were logged out of Bugzilla on October 13th, 2018

Drop |isPersisted| argument in TelemetrySend.jsm functions

NEW
Unassigned

Status

()

P4
normal
3 years ago
3 years ago

People

(Reporter: Dexter, Unassigned)

Tracking

(Blocks: 1 bug)

Trunk
Points:
---

Firefox Tracking Flags

(firefox42 affected)

Details

(Whiteboard: [unifiedTelemetry] [measurement:client])

(Reporter)

Description

3 years ago
We could remove the "isPersisted" juggling and just always call remove*Ping() in TelemetrySend [1].
If it's not persisted, TelemetryStorage will just not do anything.

[1] - https://hg.mozilla.org/mozilla-central/annotate/2ddec2dedced/toolkit/components/telemetry/TelemetrySend.jsm#l753
(Reporter)

Updated

3 years ago
Blocks: 1122482
Whiteboard: [unifiedTelemetry]
(Reporter)

Updated

3 years ago
Blocks: 1201022
No longer blocks: 1122482
We should be able to remove all the uses of |isPersisted| here:
https://dxr.mozilla.org/mozilla-central/search?q=path%3Atoolkit%2Fcomponents%2Ftelemetry%2F+isPersisted&redirect=false&case=true

... as this check only needs to check for |success|:
https://dxr.mozilla.org/mozilla-central/rev/4f4615ffec6a6a7ec40ff61ffda90a46c53f8d31/toolkit/components/telemetry/TelemetrySend.jsm#850

That cleans up & simplifies our code a little bit.
Mentor: gfritzsche
Priority: -- → P3
Whiteboard: [unifiedTelemetry] → [unifiedTelemetry] [measurement:client] [lang=js] [good next bug]

Comment 2

3 years ago
Hello i would like to work on this bug
Hi - we had an active discussions about whether we can do this as proposed in comment 0 and comment 1.
Until we resolved that, i don't think this is a good mentored bug, sorry :)

The problem here is that the suggestion in comment 0 would mean that trying to constantly remove pings that don't exist would never show up properly as an error or warning.
Mentor: gfritzsche
Whiteboard: [unifiedTelemetry] [measurement:client] [lang=js] [good next bug] → [unifiedTelemetry] [measurement:client]
Priority: P3 → P4
You need to log in before you can comment on or make changes to this bug.