Closed
Bug 1187317
Opened 9 years ago
Closed 9 years ago
redundant notification
Categories
(Firefox OS Graveyard :: Gaia::System::Status bar, Utility tray, Notification, defect)
Firefox OS Graveyard
Gaia::System::Status bar, Utility tray, Notification
Tracking
(Not tracked)
RESOLVED
FIXED
FxOS-S7 (18Sep)
People
(Reporter: nwinter, Assigned: gmarty)
Details
(Keywords: dogfood, Whiteboard: [bzlite])
Attachments
(2 files)
86.97 KB,
image/png
|
Details | |
46 bytes,
text/x-github-pull-request
|
apastor
:
review+
epang
:
ui-review+
|
Details | Review |
User-Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0 The first notification (with number of notifications) is useless and misleading. Made me believe it's clickable but nothing happens when you click on it. Takes notification screen space for nothing. Sometimes it even shows "zero notification"!
Reporter | ||
Comment 1•9 years ago
|
||
Comment 2•9 years ago
|
||
UX to look at for future design or a revision.
QA Whiteboard: [foxfood-triage]
Component: Gaia::Feedback → Gaia::System::Status bar, Utility tray, Notification
Flags: needinfo?(firefoxos-ux-bugzilla)
Comment 3•9 years ago
|
||
Passing NI to Eric as he's taking a look at notifications. Thanks for pinging the UX team!
Flags: needinfo?(firefoxos-ux-bugzilla) → needinfo?(epang)
Comment 4•9 years ago
|
||
I've never seen this notification, is it an official notification from Mozilla? If, so do we know why it's there? If not, where is it from? Seems pretty pointless if tapping it goes nowhere :) Leaving need info on myself to keep track of this bug.
Reporter | ||
Comment 5•9 years ago
|
||
I think the misleading part comes from the blue icon. "blue" color is often used for clickable things. This line is part of the utility tray.
Comment 6•9 years ago
|
||
Hi Natalia, thanks for getting back to me. Sorry, I completely misunderstood this before! What we can do is make the icon white to help with any confusion about being tappable. Guillaume, is this something you can help with? I can't remember if the notification icon in the header was an svg, if so can we update it to be #ffffff? Also can center the icon between the left edge and text? let me know if you can help, thanks!
Flags: needinfo?(gmarty)
Comment 7•9 years ago
|
||
Assignee | ||
Comment 8•9 years ago
|
||
Comment on attachment 8650470 [details] [review] [gaia] gmarty:Bug-1187317-Redundant-notification > mozilla-b2g:master I removed the color on the notification and moved it 3 pixels on the left to be aligned with the other icons on the notification. Alberto, can you take a look?
Flags: needinfo?(gmarty)
Attachment #8650470 -
Flags: review?(apastor)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → gmarty
Comment 9•9 years ago
|
||
Comment on attachment 8650470 [details] [review] [gaia] gmarty:Bug-1187317-Redundant-notification > mozilla-b2g:master The code looks good to me. Eric, can you check if that's what we visually expect? Thanks!
Attachment #8650470 -
Flags: ui-review?(epang)
Attachment #8650470 -
Flags: review?(apastor)
Attachment #8650470 -
Flags: review+
Comment 10•9 years ago
|
||
Comment on attachment 8650470 [details] [review] [gaia] gmarty:Bug-1187317-Redundant-notification > mozilla-b2g:master sorry for they delay on reviewing this. Looks good, but looks like there's been other changes to the notification tray. For example, now when there's no notification the header reads "No Notifications" instead of "0 Notifications" so we just need to make sure to lose newer changes. Thanks Guillaume!
Flags: needinfo?(epang)
Attachment #8650470 -
Flags: ui-review?(epang) → ui-review+
Comment 12•9 years ago
|
||
(In reply to Tiffanie Shakespeare [:tif] UX from comment #11) > I think Eric means "to NOT lose newer changes". :) yes!! Thanks Tiff :)
Flags: needinfo?(epang)
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 13•9 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/81b7d1916c750abb00bf52628701d7889d8fdd32
Status: NEW → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S7 (18Sep)
You need to log in
before you can comment on or make changes to this bug.
Description
•