1187339 - Always duplicate-save new main pings as aborted-session pings

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Georg Fritzsche [:gfritzsche]]

Currently, when creating new daily or other pings, we only store their payloads as "aborted-session" pings when "aborted-session" is due per the 5min interval.

This means that aborted-session can lag behind in regards to session-chaining and profileSubsessionCounter etc.

Comment 1

[Georg Fritzsche [:gfritzsche]]

Attachment: Always duplicate-save new main pings as aborted-session pings

Comment 2

[Alessio Placitelli [:Dexter]]

Comment on attachment 8639454 [details] [diff] [review]
Always duplicate-save new main pings as aborted-session pings

Review of attachment 8639454 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, r=me with the following addressed!

::: toolkit/components/telemetry/TelemetrySession.jsm
@@ +1876,5 @@
>     },
>  
>    /**
>     * Gather and send a daily ping.
>     * @param {Boolean} [saveAsAborted=false] Also saves the payload as an aborted-session

This comment needs to be updated.

@@ +1890,5 @@
>        addEnvironment: true,
>      };
>  
>      let promise = TelemetryController.submitExternalPing(getPingType(payload), payload, options);
>      // If required, also save the payload as an aborted session.

I think it would be nice to explain why we are always saving the daily ping as an aborted ping: what do you think?

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/daf25286f461

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/daf25286f461

Comment 5

[Georg Fritzsche [:gfritzsche]]

Attachment: Always duplicate-save new main pings as aborted-session pings

Comment 6

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8641667 [details] [diff] [review]
Always duplicate-save new main pings as aborted-session pings

Approval Request Comment
[Feature/regressing bug #]:
Telemetry Unification
[User impact if declined]:
This is a simple fix for when we generate backup data for detecting crashed session, which is important for crash analysis.
It is part of a mostly fixup & diagnostic uplift batch for 41: http://bit.ly/1LYhA16
[Describe test coverage new/current, TreeHerder]:
We have automated test-coverage, it baked on Nightly.
[Risks and why]:
We haven't seen anything crop up on Nightly here.
This simplifies code to simply always store the backup, so risk seems low.
[String/UUID change made/needed]:
None.

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8641667 [details] [diff] [review]
Always duplicate-save new main pings as aborted-session pings

[Triage Comment]

Patch been in m-c since 7/28 and adds improvements to crash-analysis data. Let's uplift to Beta41.

Comment 8

[Georg Fritzsche [:gfritzsche]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a0c7312b3872