Always duplicate-save new main pings as aborted-session pings

RESOLVED FIXED in Firefox 41

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: gfritzsche, Assigned: gfritzsche)

Tracking

Trunk
mozilla42
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox40 wontfix, firefox41 fixed, firefox42 fixed)

Details

(Whiteboard: [unifiedTelemetry] [uplift4])

Attachments

(1 attachment, 1 obsolete attachment)

Currently, when creating new daily or other pings, we only store their payloads as "aborted-session" pings when "aborted-session" is due per the 5min interval.

This means that aborted-session can lag behind in regards to session-chaining and profileSubsessionCounter etc.
Created attachment 8639454 [details] [diff] [review]
Always duplicate-save new main pings as aborted-session pings
Attachment #8639454 - Flags: review?(alessio.placitelli)
Assignee: nobody → gfritzsche
Status: NEW → ASSIGNED
Comment on attachment 8639454 [details] [diff] [review]
Always duplicate-save new main pings as aborted-session pings

Review of attachment 8639454 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, r=me with the following addressed!

::: toolkit/components/telemetry/TelemetrySession.jsm
@@ +1876,5 @@
>     },
>  
>    /**
>     * Gather and send a daily ping.
>     * @param {Boolean} [saveAsAborted=false] Also saves the payload as an aborted-session

This comment needs to be updated.

@@ +1890,5 @@
>        addEnvironment: true,
>      };
>  
>      let promise = TelemetryController.submitExternalPing(getPingType(payload), payload, options);
>      // If required, also save the payload as an aborted session.

I think it would be nice to explain why we are always saving the daily ping as an aborted ping: what do you think?
Attachment #8639454 - Flags: review?(alessio.placitelli) → review+
Whiteboard: [unifiedTelemetry] [uplift4]
https://hg.mozilla.org/mozilla-central/rev/daf25286f461
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-firefox42: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Created attachment 8641667 [details] [diff] [review]
Always duplicate-save new main pings as aborted-session pings
Attachment #8639454 - Attachment is obsolete: true
Iteration: --- → 42.3 - Aug 10
status-firefox39: --- → wontfix
status-firefox40: --- → affected
status-firefox39: wontfix → ---
status-firefox40: affected → wontfix
status-firefox41: --- → affected
Comment on attachment 8641667 [details] [diff] [review]
Always duplicate-save new main pings as aborted-session pings

Approval Request Comment
[Feature/regressing bug #]:
Telemetry Unification
[User impact if declined]:
This is a simple fix for when we generate backup data for detecting crashed session, which is important for crash analysis.
It is part of a mostly fixup & diagnostic uplift batch for 41: http://bit.ly/1LYhA16
[Describe test coverage new/current, TreeHerder]:
We have automated test-coverage, it baked on Nightly.
[Risks and why]:
We haven't seen anything crop up on Nightly here.
This simplifies code to simply always store the backup, so risk seems low.
[String/UUID change made/needed]:
None.
Attachment #8641667 - Flags: approval-mozilla-aurora?
Comment on attachment 8641667 [details] [diff] [review]
Always duplicate-save new main pings as aborted-session pings

[Triage Comment]

Patch been in m-c since 7/28 and adds improvements to crash-analysis data. Let's uplift to Beta41.
Attachment #8641667 - Flags: approval-mozilla-aurora? → approval-mozilla-beta+
https://hg.mozilla.org/releases/mozilla-beta/rev/a0c7312b3872
status-firefox41: affected → fixed
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.