1187360 - Straight double quotes should not break the string import process

Status: RESOLVED FIXED

(Firefox for iOS :: Build & Test, defect)

Description

[Francesco Lodolo [:flod]]

Currently, if a localization has straight double quotes, it breaks conversion from XLIFF to .strings.

We're currently escaping single quotes, but not double quotes.

Looking into /scripts, tentatively taking this bug.

Comment 1

[Francesco Lodolo [:flod]]

Attachment: Simulator screenshot

I changed locally one my strings, adding both double and single quotes.

<source>Save pages to your Reading List by tapping the book plus icon in the Reader View controls.</source>
<target>Salva pagine in "Elenco lettura" toccando l’icona con il libro e il simbolo '+' nei controlli della Modalità lettura.</target>

If I run the relevant part of scripts/import-locales.sh

rm -rf localized-strings && mkdir localized-strings
scripts/xliff-to-strings.py firefox-ios-l10n localized-strings

I get in Client/it.proj/Localizable.strings

"Save pages to your Reading List by tapping the book plus icon in the Reader View controls." = "Salva pagine in \"Elenco lettura\" toccando l’icona con il libro e il simbolo '+' nei controlli della Modalità lettura.";

That's exactly the same result I get manually importing the file in Xcode, and simulator works displaying the escaped double quotes.

What I'm missing is why we are currently escaping single quotes, but I can't see anything break.

Comment 2

[Francesco Lodolo [:flod]]

Attachment: Pull request on Github

Comment 3

[Richard Newman [:rnewman]]

I landed this, but Stefan, please take a look when you're back. See discussion on the PR.

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I think I did not escape double quotes because older Xcode versions did not deal well with those. Even if escaped. There was a discussion on the Apple Dev Forums about this where one of the dev tech support folks highly recommended to use curly quotes and never ever use double quotes.

Maybe they fixed it. Not sure. I thought it would be better to fail and tell people to use fancy quotes. Which look better anway.

Comment 5

[Richard Newman [:rnewman]]

Concur that we should use curly quotes whenever suitable for the locale. flod, can we communicate that preference to our localizers?

Comment 6

[Francesco Lodolo [:flod]]

The error message about double quotes is still in the dashboard, I should probably remove it at this point.

For single straight quotes: curly quotes (single or double) are a huge pain to type, I doubt this will have much success.

Most keyboard layouts don't include them, so you need to remap your keyboard or use awkward combinations to get them. For example, for OS X and Italian it's SHIFT+OPTION+3, but there's no trace of it on the actual key, you just need to know it exists.

FYI, English has a few strings with straight quotes, and I don't think anything broke. And we're at a point where we can't change them without asking people to relocalize these strings, since we're using the actual string as ID.

* You don't have any other devices connected to this Firefox Account available to sync.
* You don't have any tabs open in Firefox on your other devices.
* You don't have any other devices connected to this Firefox Account available to sync.
* Could not add page to Reading List. Maybe it's already there?