1187392 - Remove pin-the-web setting, and "add to homescreen" feature

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect, P2)

Description

[Ben Francis [:benfrancis]]

Add to homescreen will be replaced with pinning in 2.5

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

I believe this is already fixed as part of earlier pin-the-web work. I don't see it in the context menu anymore so I'm closing for now. Feel free to re-open if I'm wrong.

Comment 2

[Ben Francis [:benfrancis]]

Discussed in IRC, let's use this bug to track the work to remove "Add to homescreen" entirely once Pin the Web is on by default. Currently you switch between add to homescreen and pin with a pref.

Comment 3

[Michael Henretty [:mikehenrty][:mhenretty]]

We also want to use this bug for removing the setting behind which pin-the-web is hidden. This is a non-user facing feature, and so it doesn't block 2.5.

Comment 4

[Michael Henretty [:mikehenrty][:mhenretty]]

Let's disable the bookmark marionette js tests for the new homescreen for the time being, since they are flaky and they test a code path we won't support after 2.5. When we land this bug, let's just remove the tests completely.

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] mikehenrty:bug-1187392-disable-bookmark-tests > mozilla-b2g:master

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8684983 [details] [review]
[gaia] mikehenrty:bug-1187392-disable-bookmark-tests > mozilla-b2g:master

Chris, can you give the rubber stamp here?

Comment 7

[Chris Lord [:cwiiis]]

Comment on attachment 8684983 [details] [review]
[gaia] mikehenrty:bug-1187392-disable-bookmark-tests > mozilla-b2g:master

Unfortunately not, sorry :( bookmark_test can be disabled because (as you pointed out on IRC) it's covered by the pinning_the_web test... But the rest of them are testing functionality that no other marionette test hits.

We'd need to replace the bit in these tests that opens and saves a bookmark with a bit that opens and pins a site instead (which ought to be trivial, I think?)

Personally, I'd prefer to keep bookmark_test and do the same search/replace there too, I'd like to keep the tests as (for the most part) one-test-per-file (then the pinning-the-web test could be reduced to a pin-page test, I would guess?)

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

Yeah, you're probably right, we should manually convert each test. My hope was that we had enough functionality coverage in our existing pin the web tests such that we could just remove the bookmark tests. Better to convert, and indeed that was my idea in bug 1215524.

Comment 9

[BMO Automation]

Firefox OS is not being worked on