Closed
Bug 1187450
Opened 9 years ago
Closed 8 years ago
SPSProfiler::allocProfileString can leak cstr
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: erahm, Assigned: andi)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: [MemShrink:P3][CID 1306755])
Attachments
(1 file)
|
MozReview Request: Bug 1187450 - avoid leaking cstr in SPSProfiler::allocProfileString. r?jorendorff
58 bytes,
text/x-review-board-request
|
jorendorff
:
review+
|
Details |
Coverity indicates |SPSProfiler::allocProfileString| can leak |cstr| [1] if it returns early [2]. [1] https://hg.mozilla.org/mozilla-central/annotate/2ddec2dedced/js/src/vm/SPSProfiler.cpp#l337 [2] https://hg.mozilla.org/mozilla-central/annotate/2ddec2dedced/js/src/vm/SPSProfiler.cpp#l350
|
Reporter | |
Updated•9 years ago
|
Version: 33 Branch → Trunk
|
|
Reporter | |
Updated•9 years ago
|
Whiteboard: [MemShrink][CID 1306755] → [MemShrink:P3][CID 1306755]
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → bogdan.postelnicu
|
|
Assignee | |
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/36015/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/36015/
Attachment #8722408 -
Flags: review?(jorendorff)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8722408 [details] MozReview Request: Bug 1187450 - avoid leaking cstr in SPSProfiler::allocProfileString. r?jorendorff https://reviewboard.mozilla.org/r/36015/#review32697 r=me.
Attachment #8722408 -
Flags: review?(jorendorff) → review+
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/84ba22179d97
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•