Closed Bug 1187472 Opened 4 years ago Closed 4 years ago

Candidate gathering failures on UDP or TCP results in no local candidates

Categories

(Core :: WebRTC: Networking, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed
Blocking Flags:

People

(Reporter: drno, Assigned: drno)

References

Details

Attachments

(1 file)

After the landing of ICE TCP a failure to gather UDP or TCP candidates can be ignored as long as we were able to gather at least one candidate.
Blocks: 1185197
Bug 1187472: only log UDP and TCP candidate gathering failures
Attachment #8638798 - Flags: review?(docfaraday)
Attachment #8638798 - Flags: review?(docfaraday) → review+
Comment on attachment 8638798 [details]
MozReview Request: Bug 1187472: only log UDP and TCP candidate gathering failures. r=bwc

https://reviewboard.mozilla.org/r/14125/#review12727

::: media/mtransport/third_party/nICEr/src/ice/ice_component.c:601
(Diff revision 1)
> -      r_log(LOG_ICE,LOG_DEBUG,"ICE(%s): couldn't create any valid candidates",ctx->label);
> +      r_log(LOG_ICE,LOG_WARNING,"ICE(%s): couldn't create any valid candidates",ctx->label);

Let's make this an error, since it is definitely going to cause ICE to fail.
Just manually tested with e10s on an optimized Nightly build, and it fixes the problem in bug 1185197.

mreavy: this protects us against ICE TCP (and TURN TCP) usage if e10s is on (it will just do UDP). But there is no specific indicator that e10s is causing to fail the ICE TCP part. Quick attempts from me to add warning log message about this constellation failed. Do we want/need to put in more effort for adding such an interim log message (assuming that TCP e10s support will land hopefully soon)?
Flags: needinfo?(mreavy)
Comment on attachment 8638798 [details]
MozReview Request: Bug 1187472: only log UDP and TCP candidate gathering failures. r=bwc

Bug 1187472: only log UDP and TCP candidate gathering failures. r=bwc
Attachment #8638798 - Attachment description: MozReview Request: Bug 1187472: only log UDP and TCP candidate gathering failures → MozReview Request: Bug 1187472: only log UDP and TCP candidate gathering failures. r=bwc
Attachment #8638798 - Flags: review+ → review?(docfaraday)
Comment on attachment 8638798 [details]
MozReview Request: Bug 1187472: only log UDP and TCP candidate gathering failures. r=bwc

Carrying forward r+=bwc
Attachment #8638798 - Flags: review?(docfaraday) → review+
(In reply to Nils Ohlmeier [:drno] from comment #3)
> Just manually tested with e10s on an optimized Nightly build, and it fixes
> the problem in bug 1185197.
> 
> mreavy: this protects us against ICE TCP (and TURN TCP) usage if e10s is on
> (it will just do UDP). But there is no specific indicator that e10s is
> causing to fail the ICE TCP part. Quick attempts from me to add warning log
> message about this constellation failed. Do we want/need to put in more
> effort for adding such an interim log message (assuming that TCP e10s
> support will land hopefully soon)?

No, it's not worth your time to add an interim log message.  This feature is currently pref'd off and Jesup's patch is in review -- so it should land soon (almost certainly before you are ready to pref on).
Flags: needinfo?(mreavy)
Rank: 15
Priority: -- → P1
backlog: --- → webRTC+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b268245c9b6f
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.