Closed
Bug 1187510
Opened 9 years ago
Closed 9 years ago
[Calendar] App Settings Status bar is light grey, changes to gold when attempting to 'Add account'
Categories
(Firefox OS Graveyard :: Gaia::Calendar, defect)
Tracking
(blocking-b2g:2.5+, b2g-v2.2 unaffected, b2g-master verified)
VERIFIED
FIXED
blocking-b2g | 2.5+ |
Tracking | Status | |
---|---|---|
b2g-v2.2 | --- | unaffected |
b2g-master | --- | verified |
People
(Reporter: onelson, Assigned: mmedeiros)
References
()
Details
(Keywords: polish, regression, Whiteboard: [2.5-Daily-Testing], [Spark])
Attachments
(3 files)
Description: When the user is in the calendar app, they will observe that the status bar becomes tinted gold for the app. When they enter the settings for Calendar, they will observe the status bar color change to grey. If the user then proceeds to 'Add account', they will observe the status bar return to gold. This behavior seems inconsistent across the app, as the bar changes color. Seeing bug 1079213, it seems the bug may just be that the 'Add Account' page doesn't have a light grey color Repro Steps: 1) Update a Aries to 20150724113133 2) Open the Calendar app 3) Observe status bar color: gold 4) Tap the top left butto 5) Tap the gear button for settings 6) Observe status bar color: gray 7) Tap 'Add account' 8) Observe status bar color: gold Actual: Status bar color is gold on open of app, but gray in base of settings. Other options of settings have gold color. Expected: Status bar color is gold throughout Calendar app Environmental Variables: ------------------------------- Device: Aries 2.5 Build ID: 20150724113133 Gaia: db299103dd17a873cba4ff88e62ec173bf80fe62 Gecko: 9bca608ab65a Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd Version: 42.0a1 (2.5) Firmware Version: D5803_23.1.A.1.28_NCB.ftf User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0 Device: Flame 2.5 BuildID: 20150724010206 Gaia: ec2199b324304d3678b6a98a08a31bdc13c9e984 Gecko: cb8bdb8ffaef Gonk: 41d3e221039d1c4486fc13ff26793a7a39226423 Version: 42.0a1 (2.5) Firmware Version: v18D User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0 ********************************** Issue DOES NOT REPRODUCE on 2.2 for flame devices Results: Status bar color is gold throughout Calendar app Device: Flame 2.2 BuildID: 20150724002505 Gaia: e1e6317f17a840b19af9dbb25f5a771d8d9fa161 Gecko: 4cff5605633b Gonk: bd9cb3af2a0354577a6903917bc826489050b40d Version: 37.0 (2.2) Firmware Version: v18D User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0 ------------------------------- Repro frequency: 5/5 See attached: video- https://youtu.be/zKGZpSEPS7o logcat
Reporter | ||
Updated•9 years ago
|
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(pbylenga)
Comment 1•9 years ago
|
||
NI on component owner for nomination decision and assignment.
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(pbylenga) → needinfo?(twen)
Keywords: regressionwindow-wanted
Comment 2•9 years ago
|
||
Holding off on calling for a window till we determine expected behavior and blocking status.
Keywords: regressionwindow-wanted
Assignee | ||
Comment 3•9 years ago
|
||
I believe the status bar color should match the header color.. I'm almost sure the add account header used to be orange on previous builds of the calendar app. No matter which color we choose, we should probably keep it consistent (at least between add/edit accounts).
Comment 4•9 years ago
|
||
[Blocking Requested - why for this release]: Just double checked, calendar Settings and add account header are gray in 2.1 and 2.2. Status bar of calendar settings changed to gray in Aries 2.5. As per comment 3 stated, we need a consistent color setting between add/settings views. Nominate for blocking V2.5 for decision.
blocking-b2g: --- → 2.5?
Flags: needinfo?(twen)
Comment 5•9 years ago
|
||
Harly, can you give guidance here on what the status bar color should be? Should it ever change from orange? There's some confusion here resulting from bug 1079213.
Flags: needinfo?(hhsu)
Comment 6•9 years ago
|
||
The status bar color should match the header color just as Miller stated. Therefore, status bar for add account page should be grey and not gold. Thanks
Flags: needinfo?(hhsu)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → mmedeiros
Comment 7•9 years ago
|
||
[Triage] Low risk with the fix. We should have it fix for consistent user experience.
blocking-b2g: 2.5? → 2.5+
Keywords: polish
Comment 8•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8654864 -
Flags: review?(gaye)
Comment 9•9 years ago
|
||
Comment on attachment 8654864 [details] [review] [gaia] millermedeiros:1187510-toolbar-color > mozilla-b2g:master LGTM!
Attachment #8654864 -
Flags: review?(gaye) → review+
Comment 10•9 years ago
|
||
Landed on master https://github.com/mozilla-b2g/gaia/commit/7d37d7df5f8f16cec53606d3a5ee2cad8f567930
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 11•9 years ago
|
||
This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0. Actual results: Status bar color is light grey on 'Add account' page and settings page in Calendar app. See attachment: verified_AriesKK_v2.5.3gp Reproduce rate: 0/10 Device: Flame KK 2.5 (Pass) Build ID 20150901150204 Gaia Revision c2582f4be03cd12124b96a263c8d14c774f0ffe4 Gaia Date 2015-09-01 17:03:45 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/e47423c019643792e6de894cfcee598dead4d3ba Gecko Version 43.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150901.182949 Firmware Date Tue Sep 1 18:30:04 EDT 2015 Firmware Version v18D v4 Bootloader L1TC000118D0 Device: Aries KK 2.5 (Pass) Build ID 20150901190039 Gaia Revision c2582f4be03cd12124b96a263c8d14c774f0ffe4 Gaia Date 2015-09-01 17:03:45 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/e47423c019643792e6de894cfcee598dead4d3ba Gecko Version 43.0a1 Device Name aries Firmware(Release) 4.4.2 Firmware(Incremental) eng.worker.20150901.182105 Firmware Date Tue Sep 1 18:21:13 UTC 2015 Bootloader s1
Comment 12•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•