If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[Wallpaper][Camera] Wallpaper images taken from the camera will save with inconsistent cropping if the user selects 'Retake' or 'Select'

NEW
Unassigned

Status

Firefox OS
Gaia::Wallpaper
2 years ago
2 years ago

People

(Reporter: Marty, Unassigned)

Tracking

unspecified
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(tracking-b2g:backlog, b2g-v2.0 affected, b2g-v2.1 affected, b2g-v2.2 affected, b2g-master affected)

Details

(Whiteboard: [2.5-Daily-Testing][Spark])

Attachments

(3 attachments)

(Reporter)

Description

2 years ago
Created attachment 8638817 [details]
logcat-wallpaper-camera.txt

Description:
When the user takes a wallpaper image with the camera via wallpaper selection, the user will be presented with 'Retake' and 'Select' as options.  If the user chooses 'Select,' the image will automatically be cropped, and the cropped image (not the full image) will be saved to the gallery.  If the user chooses 'Retake,' the full image will be saved to the gallery.

This behavior is most obvious when taking a landscape picture.

Repro Steps:
1) Update a Aries to 20150724113133
2) Long press on the Homescreen and select "Change Wallpaper' and 'Camera'
3) Take a landscape photo, then select 'Retake'
4) Take a second, similar landscape photo, then choose 'Select'

Actual:
The full image for the first photo is saved, but only the cropped image for the second photo is saved.

Expected:
Both photos are saved as the full image.

Environmental Variables:
Device: Aries 2.5
Build ID: 20150724113133
Gaia: db299103dd17a873cba4ff88e62ec173bf80fe62
Gecko: 9bca608ab65a
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 42.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Repro frequency: 10/10
See attached: Logcat, Screenshots
(Reporter)

Comment 1

2 years ago
This issue DOES occur on Flame 2.5, 2.2, 2.1, and 2.0 builds.
The full image for the first photo is saved, but only the cropped image for the second photo is saved.

Environmental Variables:
Device: Flame 2.5
Build ID: 20150724010206
Gaia: ec2199b324304d3678b6a98a08a31bdc13c9e984
Gecko: cb8bdb8ffaef
Gonk: 41d3e221039d1c4486fc13ff26793a7a39226423
Version: 42.0a1 (2.5)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Environmental Variables:
Device: Flame 2.2
Build ID: 20150724002505
Gaia: e1e6317f17a840b19af9dbb25f5a771d8d9fa161
Gecko: 4cff5605633b
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Environmental Variables:
Device: Flame 2.1 Kk Full flash (319mb)
Build ID: 20150724001207
Gaia: 9dba58d18006e921546cec62c76074ce81e16518
Gecko: 41e10c6740be
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 34.0 (2.1)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Environmental Variables:
Device: Flame 2.0
Build ID: 20150723000207
Gaia: b16ba05481e577bc644ed8966f587a70fe2148e6
Gecko: 2e6f1d4deff9
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 32.0 (2.0)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(onelson)
(Reporter)

Comment 2

2 years ago
Created attachment 8638826 [details]
Image-Saved-From-Retake.jpg
(Reporter)

Comment 3

2 years ago
Created attachment 8638828 [details]
Image-Saved-From-Select.jpg

Attached are two similar images, both taken in landscape. One was found after in gallery selecting 'Retake,' the other after selecting 'Select'
[Blocking Requested - why for this release]:
Nominating for block as taking landscape pictures through share activity for wallpaper is saving odd croppings of the images to the user's gallery. Has the potential to bloat the user's gallery or give them a wallpaper image they didn't expect.
blocking-b2g: --- → 2.5?
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(onelson) → needinfo?(npark)
Although it's not a regression, I think this is a blocker as well. Hema, what do you think?
Flags: needinfo?(npark) → needinfo?(hkoka)

Comment 6

2 years ago
[Tracking Requested - why for this release]:

Hmm, I agree that the behavior is inconsistent with retake and select -- seems to be an old issue with the way it is implemented. 

I have seen related bugs around the cropping function. See also: https://bugzilla.mozilla.org/show_bug.cgi?id=953412, https://bugzilla.mozilla.org/show_bug.cgi?id=993651, https://bugzilla.mozilla.org/show_bug.cgi?id=1090782.

Not blocking release, but adding to backlog to fix and copying david and punam to keep this in their radar.
blocking-b2g: 2.5? → ---
tracking-b2g: --- → backlog
Flags: needinfo?(hkoka)
You need to log in before you can comment on or make changes to this bug.