calendar.context.togglevisible.accesskey is used for multiple strings

RESOLVED FIXED in 4.4

Status

Calendar
Calendar Views
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: MikkCZ, Assigned: mmecca)

Tracking

Lightning 4.0.1.2
Dependency tree / graph

Details

(URL)

Attachments

(1 attachment)

The calendar.context.togglevisible.accesskey applies to showCalendar as well as hideCalendar strings, which does not correspond the l10n files comments, where only showCalendar is mentioned.

Both the strings should have separate accesskeys, because if the calendar.context.togglevisible.accesskey letter is not in the localized hideCalendar string, it will be appended in brackets.
(Assignee)

Comment 1

2 years ago
Created attachment 8638928 [details] [diff] [review]
Fix v1

Uses a separate access key for Show and Hide calendar
Assignee: nobody → matthew.mecca
Status: NEW → ASSIGNED
Attachment #8638928 - Flags: review?(philipp)
Comment on attachment 8638928 [details] [diff] [review]
Fix v1

Review of attachment 8638928 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the quick patch, r=philipp
Attachment #8638928 - Flags: review?(philipp) → review+
Keywords: checkin-needed

Comment 3

2 years ago
https://hg.mozilla.org/comm-central/rev/5a7b45efb096
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 4.4
Duplicate of this bug: 1178118
You need to log in before you can comment on or make changes to this bug.