Closed
Bug 1187574
Opened 9 years ago
Closed 9 years ago
calendar.context.togglevisible.accesskey is used for multiple strings
Categories
(Calendar :: Calendar Frontend, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
4.4
People
(Reporter: mstanke, Assigned: mmecca)
References
()
Details
Attachments
(1 file)
|
4.76 KB,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
The calendar.context.togglevisible.accesskey applies to showCalendar as well as hideCalendar strings, which does not correspond the l10n files comments, where only showCalendar is mentioned. Both the strings should have separate accesskeys, because if the calendar.context.togglevisible.accesskey letter is not in the localized hideCalendar string, it will be appended in brackets.
|
Assignee | |
Comment 1•9 years ago
|
||
Uses a separate access key for Show and Hide calendar
Assignee: nobody → matthew.mecca
Status: NEW → ASSIGNED
Attachment #8638928 -
Flags: review?(philipp)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8638928 [details] [diff] [review] Fix v1 Review of attachment 8638928 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for the quick patch, r=philipp
Attachment #8638928 -
Flags: review?(philipp) → review+
|
|
||
Updated•9 years ago
|
Keywords: checkin-needed
|
||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/comm-central/rev/5a7b45efb096
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 4.4
You need to log in
before you can comment on or make changes to this bug.
Description
•