Infinite (async) loop when creating breadcrumbs for parent with > 10 LOW_PRIORITY_ELEMENTS children

RESOLVED FIXED in Firefox 42

Status

()

Firefox
Developer Tools: Inspector
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Simon Lindholm, Assigned: Simon Lindholm)

Tracking

unspecified
Firefox 42
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
STR:
1. visit http://xkcd.com, open the inspector
2. select the <head> element

-> CPU usage becomes ~100%, and the extra breadcrumb next to "head" never appears.
(Assignee)

Comment 1

2 years ago
Created attachment 8638900 [details] [diff] [review]
0001-Bug-1187578-Avoid-infinite-loop-when-creating-breadc.patch

green try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e0e4caf27df7
Attachment #8638900 - Flags: review?(bgrinstead)
Summary: Infinite (async) loop when creating breadcrumbs → Infinite (async) loop when creating breadcrumbs for parent with > 10 LOW_PRIORITY_ELEMENTS children
Comment on attachment 8638900 [details] [diff] [review]
0001-Bug-1187578-Avoid-infinite-loop-when-creating-breadc.patch

Review of attachment 8638900 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch, thanks.  I have a regression test incoming
Attachment #8638900 - Flags: review?(bgrinstead) → review+
Created attachment 8639354 [details] [diff] [review]
breadcrumb-test.patch

Simple regression test for this bug
Attachment #8639354 - Flags: review+
Status: NEW → ASSIGNED
Try push with the test included: https://treeherder.mozilla.org/#/jobs?repo=try&revision=56844df22f02
Keywords: checkin-needed

Comment 5

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/401b8c51f0ed
https://hg.mozilla.org/integration/fx-team/rev/f027369b116a
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/401b8c51f0ed
https://hg.mozilla.org/mozilla-central/rev/f027369b116a
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
You need to log in before you can comment on or make changes to this bug.