Closed Bug 1187578 Opened 10 years ago Closed 10 years ago

Infinite (async) loop when creating breadcrumbs for parent with > 10 LOW_PRIORITY_ELEMENTS children

Categories

(DevTools :: Inspector, defect)

Product:
DevTools
Component:
Inspector
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox42 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 42
Tracking Flags:
Tracking Status
firefox42 --- fixed

People

(Reporter: simon.lindholm10, Assigned: simon.lindholm10)

Details

Attachments

(2 files)

0001-Bug-1187578-Avoid-infinite-loop-when-creating-breadc.patch
1.50 KB, patch
bgrins
: review+
Details | Diff | Splinter Review
breadcrumb-test.patch
2.04 KB, patch
bgrins
: review+
Details | Diff | Splinter Review
STR: 1. visit http://xkcd.com, open the inspector 2. select the <head> element -> CPU usage becomes ~100%, and the extra breadcrumb next to "head" never appears.
Summary: Infinite (async) loop when creating breadcrumbs → Infinite (async) loop when creating breadcrumbs for parent with > 10 LOW_PRIORITY_ELEMENTS children
Comment on attachment 8638900 [details] [diff] [review] 0001-Bug-1187578-Avoid-infinite-loop-when-creating-breadc.patch Review of attachment 8638900 [details] [diff] [review]: ----------------------------------------------------------------- Good catch, thanks. I have a regression test incoming
Attachment #8638900 - Flags: review?(bgrinstead) → review+
Simple regression test for this bug
Attachment #8639354 - Flags: review+
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/401b8c51f0ed https://hg.mozilla.org/mozilla-central/rev/f027369b116a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: