Fix fallout from bug 905127 due to missing headers for suite/ on osx64

RESOLVED FIXED in seamonkey2.39

Status

--
critical
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: ewong, Assigned: ewong)

Tracking

Trunk
seamonkey2.39
x86
Mac OS X
Dependency tree / graph

Firefox Tracking Flags

(firefox42 affected)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
Sorry...  missed out on the Mac platform for this bug.
+++ This bug was initially created as a clone of Bug #1181895 +++

Once bug 1181434 is fixed, this bug will cover the code for suite/.

Rationale: Folding libsuite into xul requires quite a bit of change
to the code (particularly now that suite/ isn't non-Mozilla_internal,
we can now use nsString.h instead of nsStringAPI.h.)

Now the question that I'd like to pose is whether or not this is
the 'right' thing to do.  Being ignorant in why libsuite was
kept separate from libxul,  does it make sense to fold it into
libxul? 



+++ This bug was initially created as a clone of Bug #1181434 +++

Current trunk bustage:


libmailnews_extensions_mdn_src.a.desc
rm -f libmailnews_extensions_mdn_src.a
/builds/slave/c-cen-t-lnx/build/objdir/_virtualenv/bin/python /builds/slave/c-cen-t-lnx/build/mozilla/config/expandlibs_gen.py -o libmailnews_extensions_mdn_src.a.desc nsMsgMdnGenerator.o  
make[4]: Leaving directory `/builds/slave/c-cen-t-lnx/build/objdir/mailnews/extensions/mdn/src'
make[4]: Entering directory `/builds/slave/c-cen-t-lnx/build/objdir/mailnews/base/util'
mkdir -p '.deps/'
Services.o
/usr/bin/ccache /tools/gcc-4.7.3-0moz1/bin/g++ -o Services.o -c -I../../../dist/stl_wrappers -I../../../dist/system_wrappers -include /builds/slave/c-cen-t-lnx/build/mozilla/config/gcc_hidden.h -D_IMPL_NS_MSG_BASE -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DAB_CD=en-US -DNO_NSPR_10_SUPPORT -I/builds/slave/c-cen-t-lnx/build/mailnews/base/util -I. -I/builds/slave/c-cen-t-lnx/build/mozilla/netwerk/base -I../../../dist/include   -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nspr -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nss       -fPIC   -DMOZILLA_CLIENT -include ../../../mozilla-config.h -MD -MP -MF .deps/Services.o.pp  -Wall -Wempty-body -Woverloaded-virtual -Wsign-compare -Wwrite-strings -Wno-invalid-offsetof -Wcast-align -gdwarf-2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -D_GLIBCXX_USE_CXX11_ABI=0 -pipe  -DNDEBUG -DTRIMMED -gdwarf-2 -freorder-blocks -Os -fno-omit-frame-pointer     /builds/slave/c-cen-t-lnx/build/mailnews/base/util/Services.cpp
nsImapMoveCoalescer.o
/usr/bin/ccache /tools/gcc-4.7.3-0moz1/bin/g++ -o nsMsgFilterList.o -c -I../../../../dist/stl_wrappers -I../../../../dist/system_wrappers -include /builds/slave/c-cen-t-lnx/build/mozilla/config/gcc_hidden.h -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DAB_CD=en-US -DNO_NSPR_10_SUPPORT -I/builds/slave/c-cen-t-lnx/build/mailnews/base/search/src -I.  -I../../../../dist/include   -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nspr -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nss       -fPIC   -DMOZILLA_CLIENT -include ../../../../mozilla-config.h -MD -MP -MF .deps/nsMsgFilterList.o.pp  -Wall -Wempty-body -Woverloaded-virtual -Wsign-compare -Wwrite-strings -Wno-invalid-offsetof -Wcast-align -gdwarf-2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -D_GLIBCXX_USE_CXX11_ABI=0 -pipe  -DNDEBUG -DTRIMMED -gdwarf-2 -freorder-blocks -Os -fno-omit-frame-pointer     /builds/slave/c-cen-t-lnx/build/mailnews/base/search/src/nsMsgFilterList.cpp
nsMsgFilterService.o
/usr/bin/ccache /tools/gcc-4.7.3-0moz1/bin/g++ -o nsImapMoveCoalescer.o -c -I../../../dist/stl_wrappers -I../../../dist/system_wrappers -include /builds/slave/c-cen-t-lnx/build/mozilla/config/gcc_hidden.h -D_IMPL_NS_MSG_BASE -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DAB_CD=en-US -DNO_NSPR_10_SUPPORT -I/builds/slave/c-cen-t-lnx/build/mailnews/base/util -I. -I/builds/slave/c-cen-t-lnx/build/mozilla/netwerk/base -I../../../dist/include   -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nspr -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nss       -fPIC   -DMOZILLA_CLIENT -include ../../../mozilla-config.h -MD -MP -MF .deps/nsImapMoveCoalescer.o.pp  -Wall -Wempty-body -Woverloaded-virtual -Wsign-compare -Wwrite-strings -Wno-invalid-offsetof -Wcast-align -gdwarf-2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -D_GLIBCXX_USE_CXX11_ABI=0 -pipe  -DNDEBUG -DTRIMMED -gdwarf-2 -freorder-blocks -Os -fno-omit-frame-pointer     /builds/slave/c-cen-t-lnx/build/mailnews/base/util/nsImapMoveCoalescer.cpp
nsMsgCompressIStream.o
/usr/bin/ccache /tools/gcc-4.7.3-0moz1/bin/g++ -o nsLocalUtils.o -c -I../../../dist/stl_wrappers -I../../../dist/system_wrappers -include /builds/slave/c-cen-t-lnx/build/mozilla/config/gcc_hidden.h -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DAB_CD=en-US -DNO_NSPR_10_SUPPORT -I/builds/slave/c-cen-t-lnx/build/mailnews/local/src -I.  -I../../../dist/include   -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nspr -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nss       -fPIC   -DMOZILLA_CLIENT -include ../../../mozilla-config.h -MD -MP -MF .deps/nsLocalUtils.o.pp  -Wall -Wempty-body -Woverloaded-virtual -Wsign-compare -Wwrite-strings -Wno-invalid-offsetof -Wcast-align -gdwarf-2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -D_GLIBCXX_USE_CXX11_ABI=0 -pipe  -DNDEBUG -DTRIMMED -gdwarf-2 -freorder-blocks -Os -fno-omit-frame-pointer     /builds/slave/c-cen-t-lnx/build/mailnews/local/src/nsLocalUtils.cpp
nsMailboxProtocol.o
../../../../../mailnews/base/search/src/nsMsgFilterList.cpp: In member function ‘char nsMsgFilterList::ReadChar(nsIInputStream*)’:
../../../../../mailnews/base/search/src/nsMsgFilterList.cpp:385:24: error: invalid use of incomplete type ‘class nsIInputStream’
In file included from ../../../../../mailnews/base/search/src/nsMsgFilterList.h:10:0,
                 from ../../../../../mailnews/base/search/src/nsMsgFilterList.cpp:11:
../../../../dist/include/nsIMsgFolder.h:51:7: error: forward declaration of ‘class nsIInputStream’
../../../../../mailnews/base/search/src/nsMsgFilterList.cpp:389:15: error: invalid use of incomplete type ‘class nsIInputStream’
In file included from ../../../../../mailnews/base/search/src/nsMsgFilterList.h:10:0,
                 from ../../../../../mailnews/base/search/src/nsMsgFilterList.cpp:11:
../../../../dist/include/nsIMsgFolder.h:51:7: error: forward declaration of ‘class nsIInputStream’
../../../../../mailnews/base/search/src/nsMsgFilterList.cpp: In member function ‘nsresult nsMsgFilterList::LoadTextFilters(nsIInputStream*)’:
../../../../../mailnews/base/search/src/nsMsgFilterList.cpp:704:65: error: invalid use of incomplete type ‘class nsIInputStream’
In file included from ../../../../../mailnews/base/search/src/nsMsgFilterList.h:10:0,
                 from ../../../../../mailnews/base/search/src/nsMsgFilterList.cpp:11:
../../../../dist/include/nsIMsgFolder.h:51:7: error: forward declaration of ‘class nsIInputStream’
make[4]: *** [nsMsgFilterList.o] Error 1
make[4]: Leaving directory `/builds/slave/c-cen-t-lnx/build/objdir/mailnews/base/search/src'
make[3]: *** [mailnews/base/search/src/target] Error 2
make[3]: *** Waiting for unfinished jobs....
/usr/bin/ccache /tools/gcc-4.7.3-0moz1/bin/g++ -o nsMailboxProtocol.o -c -I../../../dist/stl_wrappers -I../../../dist/system_wrappers -include /builds/slave/c-cen-t-lnx/build/mozilla/config/gcc_hidden.h -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DAB_CD=en-US -DNO_NSPR_10_SUPPORT -I/builds/slave/c-cen-t-lnx/build/mailnews/local/src -I.  -I../../../dist/include   -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nspr -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nss       -fPIC   -DMOZILLA_CLIENT -include ../../../mozilla-config.h -MD -MP -MF .deps/nsMailboxProtocol.o.pp  -Wall -Wempty-body -Woverloaded-virtual -Wsign-compare -Wwrite-strings -Wno-invalid-offsetof -Wcast-align -gdwarf-2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -D_GLIBCXX_USE_CXX11_ABI=0 -pipe  -DNDEBUG -DTRIMMED -gdwarf-2 -freorder-blocks -Os -fno-omit-frame-pointer     /builds/slave/c-cen-t-lnx/build/mailnews/local/src/nsMailboxProtocol.cpp
nsMailboxServer.o
/usr/bin/ccache /tools/gcc-4.7.3-0moz1/bin/g++ -o nsMsgCompressIStream.o -c -I../../../dist/stl_wrappers -I../../../dist/system_wrappers -include /builds/slave/c-cen-t-lnx/build/mozilla/config/gcc_hidden.h -D_IMPL_NS_MSG_BASE -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DAB_CD=en-US -DNO_NSPR_10_SUPPORT -I/builds/slave/c-cen-t-lnx/build/mailnews/base/util -I. -I/builds/slave/c-cen-t-lnx/build/mozilla/netwerk/base -I../../../dist/include   -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nspr -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nss       -fPIC   -DMOZILLA_CLIENT -include ../../../mozilla-config.h -MD -MP -MF .deps/nsMsgCompressIStream.o.pp  -Wall -Wempty-body -Woverloaded-virtual -Wsign-compare -Wwrite-strings -Wno-invalid-offsetof -Wcast-align -gdwarf-2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -D_GLIBCXX_USE_CXX11_ABI=0 -pipe  -DNDEBUG -DTRIMMED -gdwarf-2 -freorder-blocks -Os -fno-omit-frame-pointer     /builds/slave/c-cen-t-lnx/build/mailnews/base/util/nsMsgCompressIStream.cpp
nsMsgCompressOStream.o
/usr/bin/ccache /tools/gcc-4.7.3-0moz1/bin/g++ -o StructuredClone.o -c -I../../dist/stl_wrappers -I../../dist/system_wrappers -include /builds/slave/c-cen-t-lnx/build/mozilla/config/gcc_hidden.h -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DAB_CD=en-US -DNO_NSPR_10_SUPPORT -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/bindings -I. -I../../dist/include/mozilla/dom -I/builds/slave/c-cen-t-lnx/build/objdir/ipc/ipdl/_ipdlheaders -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/base -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/battery -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/bluetooth -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/camera -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/canvas -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/geolocation -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/html -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/indexedDB -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/media/webaudio -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/media/webspeech/recognition -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/svg -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/workers -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/xbl -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/xml -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/xslt/base -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/xslt/xpath -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/xul -I/builds/slave/c-cen-t-lnx/build/mozilla/js/xpconnect/src -I/builds/slave/c-cen-t-lnx/build/mozilla/js/xpconnect/wrappers -I/builds/slave/c-cen-t-lnx/build/mozilla/layout/style -I/builds/slave/c-cen-t-lnx/build/mozilla/layout/xul/tree -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport -I/builds/slave/c-cen-t-lnx/build/mozilla/media/webrtc/ -I/builds/slave/c-cen-t-lnx/build/mozilla/media/webrtc/signaling/src/common/time_profiling -I/builds/slave/c-cen-t-lnx/build/mozilla/media/webrtc/signaling/src/peerconnection -I/builds/slave/c-cen-t-lnx/build/mozilla/ipc/chromium/src -I/builds/slave/c-cen-t-lnx/build/mozilla/ipc/glue -I/builds/slave/c-cen-t-lnx/build/mozilla/dom/bluetooth/bluetooth2 -I../../dist/include   -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nspr -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nss       -fPIC   -DMOZILLA_CLIENT -include ../../mozilla-config.h -MD -MP -MF .deps/StructuredClone.o.pp  -Wall -Wempty-body -Woverloaded-virtual -Wsign-compare -Wwrite-strings -Wno-invalid-offsetof -Wcast-align -gdwarf-2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -D_GLIBCXX_USE_CXX11_ABI=0 -pipe -Wno-uninitialized  -DNDEBUG -DTRIMMED -gdwarf-2 -freorder-blocks -Os -fno-omit-frame-pointer      /builds/slave/c-cen-t-lnx/build/mozilla/dom/bindings/StructuredClone.cpp
Unified_cpp_dom_bindings0.o
/usr/bin/ccache /tools/gcc-4.7.3-0moz1/bin/g++ -o nsMsgCompressOStream.o -c -I../../../dist/stl_wrappers -I../../../dist/system_wrappers -include /builds/slave/c-cen-t-lnx/build/mozilla/config/gcc_hidden.h -D_IMPL_NS_MSG_BASE -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DAB_CD=en-US -DNO_NSPR_10_SUPPORT -I/builds/slave/c-cen-t-lnx/build/mailnews/base/util -I. -I/builds/slave/c-cen-t-lnx/build/mozilla/netwerk/base -I../../../dist/include   -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nspr -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nss       -fPIC   -DMOZILLA_CLIENT -include ../../../mozilla-config.h -MD -MP -MF .deps/nsMsgCompressOStream.o.pp  -Wall -Wempty-body -Woverloaded-virtual -Wsign-compare -Wwrite-strings -Wno-invalid-offsetof -Wcast-align -gdwarf-2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -D_GLIBCXX_USE_CXX11_ABI=0 -pipe  -DNDEBUG -DTRIMMED -gdwarf-2 -freorder-blocks -Os -fno-omit-frame-pointer     /builds/slave/c-cen-t-lnx/build/mailnews/base/util/nsMsgCompressOStream.cpp
nsMsgDBFolder.o
/usr/bin/ccache /tools/gcc-4.7.3-0moz1/bin/g++ -o nsMsgDBFolder.o -c -I../../../dist/stl_wrappers -I../../../dist/system_wrappers -include /builds/slave/c-cen-t-lnx/build/mozilla/config/gcc_hidden.h -D_IMPL_NS_MSG_BASE -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DAB_CD=en-US -DNO_NSPR_10_SUPPORT -I/builds/slave/c-cen-t-lnx/build/mailnews/base/util -I. -I/builds/slave/c-cen-t-lnx/build/mozilla/netwerk/base -I../../../dist/include   -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nspr -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nss       -fPIC   -DMOZILLA_CLIENT -include ../../../mozilla-config.h -MD -MP -MF .deps/nsMsgDBFolder.o.pp  -Wall -Wempty-body -Woverloaded-virtual -Wsign-compare -Wwrite-strings -Wno-invalid-offsetof -Wcast-align -gdwarf-2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -D_GLIBCXX_USE_CXX11_ABI=0 -pipe  -DNDEBUG -DTRIMMED -gdwarf-2 -freorder-blocks -Os -fno-omit-frame-pointer     /builds/slave/c-cen-t-lnx/build/mailnews/base/util/nsMsgDBFolder.cpp
nsMsgFileStream.o
../../../../mailnews/local/src/nsMailboxProtocol.cpp: In member function ‘virtual nsresult nsMailboxProtocol::OnStopRequest(nsIRequest*, nsISupports*, nsresult)’:
../../../../mailnews/local/src/nsMailboxProtocol.cpp:341:32: error: invalid use of incomplete type ‘class nsIInputStreamPump’
In file included from ../../../../mailnews/local/src/nsMailboxProtocol.cpp:29:0:
../../../dist/include/nsNetUtil.h:33:7: error: forward declaration of ‘class nsIInputStreamPump’
../../../../mailnews/local/src/nsMailboxProtocol.cpp:343:37: error: no match for ‘operator=’ in ‘((nsMailboxProtocol*)this)->nsMailboxProtocol::<anonymous>.nsMsgProtocol::m_request = pump’
../../../../mailnews/local/src/nsMailboxProtocol.cpp:343:37: note: candidates are:
In file included from ../../../dist/include/nsComponentManagerUtils.h:11:0,
                 from ../../../dist/include/nsIServiceManager.h:130,
                 from ../../../dist/include/msgCore.h:21,
                 from ../../../../mailnews/local/src/nsMailboxProtocol.cpp:6:
../../../dist/include/nsCOMPtr.h:542:16: note: nsCOMPtr<T>& nsCOMPtr<T>::operator=(const nsCOMPtr<T>&) [with T = nsIRequest]
../../../dist/include/nsCOMPtr.h:542:16: note:   no known conversion for argument 1 from ‘nsCOMPtr<nsIInputStreamPump>’ to ‘const nsCOMPtr<nsIRequest>&’
../../../dist/include/nsCOMPtr.h:548:16: note: nsCOMPtr<T>& nsCOMPtr<T>::operator=(T*) [with T = nsIRequest]
../../../dist/include/nsCOMPtr.h:548:16: note:   no known conversion for argument 1 from ‘nsCOMPtr<nsIInputStreamPump>’ to ‘nsIRequest*’
../../../dist/include/nsCOMPtr.h:557:16: note: template<class U> nsCOMPtr& nsCOMPtr::operator=(already_AddRefed<U>&) [with U = U; T = nsIRequest]
../../../dist/include/nsCOMPtr.h:557:16: note:   template argument deduction/substitution failed:
../../../../mailnews/local/src/nsMailboxProtocol.cpp:343:37: note:   ‘nsCOMPtr<nsIInputStreamPump>’ is not derived from ‘already_AddRefed<T>’
In file included from ../../../dist/include/nsComponentManagerUtils.h:11:0,
                 from ../../../dist/include/nsIServiceManager.h:130,
                 from ../../../dist/include/msgCore.h:21,
                 from ../../../../mailnews/local/src/nsMailboxProtocol.cpp:6:
../../../dist/include/nsCOMPtr.h:569:16: note: template<class U> nsCOMPtr& nsCOMPtr::operator=(already_AddRefed<U>&&) [with U = U; T = nsIRequest]
../../../dist/include/nsCOMPtr.h:569:16: note:   template argument deduction/substitution failed:
../../../../mailnews/local/src/nsMailboxProtocol.cpp:343:37: note:   ‘nsCOMPtr<nsIInputStreamPump>’ is not derived from ‘already_AddRefed<T>’
In file included from ../../../dist/include/nsComponentManagerUtils.h:11:0,
                 from ../../../dist/include/nsIServiceManager.h:130,
                 from ../../../dist/include/msgCore.h:21,
                 from ../../../../mailnews/local/src/nsMailboxProtocol.cpp:6:
../../../dist/include/nsCOMPtr.h:580:16: note: nsCOMPtr<T>& nsCOMPtr<T>::operator=(nsQueryInterface) [with T = nsIRequest]
../../../dist/include/nsCOMPtr.h:580:16: note:   no known conversion for argument 1 from ‘nsCOMPtr<nsIInputStreamPump>’ to ‘nsQueryInterface’
../../../dist/include/nsCOMPtr.h:587:16: note: nsCOMPtr<T>& nsCOMPtr<T>::operator=(const nsQueryInterfaceWithError&) [with T = nsIRequest]
../../../dist/include/nsCOMPtr.h:587:16: note:   no known conversion for argument 1 from ‘nsCOMPtr<nsIInputStreamPump>’ to ‘const nsQueryInterfaceWithError&’
../../../dist/include/nsCOMPtr.h:594:16: note: nsCOMPtr<T>& nsCOMPtr<T>::operator=(nsGetServiceByCID) [with T = nsIRequest]
../../../dist/include/nsCOMPtr.h:594:16: note:   no known conversion for argument 1 from ‘nsCOMPtr<nsIInputStreamPump>’ to ‘nsGetServiceByCID’
../../../dist/include/nsCOMPtr.h:601:16: note: nsCOMPtr<T>& nsCOMPtr<T>::operator=(const nsGetServiceByCIDWithError&) [with T = nsIRequest]
../../../dist/include/nsCOMPtr.h:601:16: note:   no known conversion for argument 1 from ‘nsCOMPtr<nsIInputStreamPump>’ to ‘const nsGetServiceByCIDWithError&’
../../../dist/include/nsCOMPtr.h:608:16: note: nsCOMPtr<T>& nsCOMPtr<T>::operator=(nsGetServiceByContractID) [with T = nsIRequest]
../../../dist/include/nsCOMPtr.h:608:16: note:   no known conversion for argument 1 from ‘nsCOMPtr<nsIInputStreamPump>’ to ‘nsGetServiceByContractID’
../../../dist/include/nsCOMPtr.h:615:16: note: nsCOMPtr<T>& nsCOMPtr<T>::operator=(const nsGetServiceByContractIDWithError&) [with T = nsIRequest]
../../../dist/include/nsCOMPtr.h:615:16: note:   no known conversion for argument 1 from ‘nsCOMPtr<nsIInputStreamPump>’ to ‘const nsGetServiceByContractIDWithError&’
../../../dist/include/nsCOMPtr.h:623:16: note: nsCOMPtr<T>& nsCOMPtr<T>::operator=(const nsCOMPtr_helper&) [with T = nsIRequest]
../../../dist/include/nsCOMPtr.h:623:16: note:   no known conversion for argument 1 from ‘nsCOMPtr<nsIInputStreamPump>’ to ‘const nsCOMPtr_helper&’
../../../dist/include/nsCOMPtr.h:632:16: note: template<class U> nsCOMPtr& nsCOMPtr::operator=(const mozilla::dom::OwningNonNull<U>&) [with U = U; T = nsIRequest]
../../../dist/include/nsCOMPtr.h:632:16: note:   template argument deduction/substitution failed:
../../../../mailnews/local/src/nsMailboxProtocol.cpp:343:37: note:   ‘nsCOMPtr<nsIInputStreamPump>’ is not derived from ‘const mozilla::dom::OwningNonNull<U>’
make[4]: *** [nsMailboxProtocol.o] Error 1
make[4]: Leaving directory `/builds/slave/c-cen-t-lnx/build/objdir/mailnews/local/src'
make[3]: *** [mailnews/local/src/target] Error 2
(Assignee)

Comment 1

3 years ago
For the following bustage:

/builds/slave/c-cen-t-osx64-dbg/build/clang/bin/clang++ -o nsThunderbirdProfileMigrator.o -c  -fvisibility=hidden -fvisibility-inlines-hidden -DAB_CD=en-US -DNO_NSPR_10_SUPPORT -I/builds/slave/c-cen-t-osx64-dbg/build/suite/profile/migration/src -I.  -I../../../../dist/include   -I/builds/slave/c-cen-t-osx64-dbg/build/objdir/dist/include/nspr -I/builds/slave/c-cen-t-osx64-dbg/build/objdir/dist/include/nss       -fPIC  -Qunused-arguments  -DMOZILLA_CLIENT -include ../../../../mozilla-config.h -MD -MP -MF .deps/nsThunderbirdProfileMigrator.o.pp -Qunused-arguments  -Qunused-arguments -Wall -Wempty-body -Woverloaded-virtual -Wsign-compare -Wwrite-strings -Wno-invalid-offsetof -Wno-c++0x-extensions -Wno-extended-offsetof -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -DNO_X11 -pipe  -DDEBUG -DTRACING -gdwarf-2 -O3 -fno-omit-frame-pointer     /builds/slave/c-cen-t-osx64-dbg/build/suite/profile/migration/src/nsThunderbirdProfileMigrator.cpp
/builds/slave/c-cen-t-osx64-dbg/build/suite/shell/src/nsMacShellService.cpp:107:33: error: use of undeclared identifier 'do_GetService'
  nsCOMPtr<nsIPrefBranch> prefs(do_GetService(NS_PREFSERVICE_CONTRACTID, &rv));
                                ^
/builds/slave/c-cen-t-osx64-dbg/build/suite/shell/src/nsMacShellService.cpp:116:33: error: use of undeclared identifier 'do_GetService'
  nsCOMPtr<nsIPrefBranch> prefs(do_GetService(NS_PREFSERVICE_CONTRACTID, &rv));
                                ^
/builds/slave/c-cen-t-osx64-dbg/build/suite/shell/src/nsMacShellService.cpp:154:33: error: use of undeclared identifier 'do_GetService'
  nsCOMPtr<nsIPrefBranch> prefs(do_GetService(NS_PREFSERVICE_CONTRACTID, &rv));
                                ^
/builds/slave/c-cen-t-osx64-dbg/build/suite/shell/src/nsMacShellService.cpp:166:33: error: use of undeclared identifier 'do_GetService'
  nsCOMPtr<nsIPrefBranch> prefs(do_GetService(NS_PREFSERVICE_CONTRACTID, &rv));
                                ^
/builds/slave/c-cen-t-osx64-dbg/build/suite/shell/src/nsMacShellService.cpp:210:12: error: use of undeclared identifier 'nsIProperties'; did you mean 'pProperties'?
  nsCOMPtr<nsIProperties> fileLocator
           ^~~~~~~~~~~~~
           pProperties
/System/Library/Frameworks/Carbon.framework/Frameworks/OpenScripting.framework/Headers/ASRegistry.h:109:3: note: 'pProperties' declared here
  pProperties                   = 'pALL', /* User-Defined Record Fields: */
  ^
/builds/slave/c-cen-t-osx64-dbg/build/suite/shell/src/nsMacShellService.cpp:210:12: error: template argument for template type parameter must be a type
  nsCOMPtr<nsIProperties> fileLocator
           ^~~~~~~~~~~~~
../../../dist/include/nsNetUtil.h:48:11: note: template parameter is declared here
template <class> class nsCOMPtr;
          ^
/builds/slave/c-cen-t-osx64-dbg/build/suite/shell/src/nsMacShellService.cpp:211:6: error: use of undeclared identifier 'do_GetService'
    (do_GetService("@mozilla.org/file/directory_service;1", &rv));
     ^
7 errors generated.
make[4]: *** [nsMacShellService.o] Error 1
make[3]: *** [suite/shell/src/target] Error 2
make[3]: *** Waiting for unfinished jobs....
libsuite_profile_migration_src.a.desc
rm -f libsuite_profile_migration_src.a
/builds/slave/c-cen-t-osx64-dbg/build/objdir/_virtualenv/bin/python /builds/slave/c-cen-t-osx64-dbg/build/mozilla/config/expandlibs_gen.py -o libsuite_profile_migration_src.a.desc nsNetscapeProfileMigratorBase.o nsSuiteProfileMigratorUtils.o nsThunderbirdProfileMigrator.o  
make[2]: *** [compile] Error 2
make[1]: *** [default] Error 2
make: *** [build] Error 2
(Assignee)

Comment 2

3 years ago
Created attachment 8638926 [details] [diff] [review]
proposed patch (v1)

As I have no access to a Mac..  Stefan, can you check if this patch builds?
(or anyone who has access to a Mac for that matter...  I've pushed my
patch to try with a tweak of the mozconfig to have it build suite .. dunno if that's gonna work.)
Attachment #8638926 - Flags: feedback?(stefanh)

Comment 3

3 years ago
Comment on attachment 8638926 [details] [diff] [review]
proposed patch (v1)

Yeah, this builds fine.

> #include "nsILoadContext.h"
> 
> #include <ApplicationServices/ApplicationServices.h>
> 
>+#include "nsServiceManagerUtils.h"
>+#include "nsIProperties.h"
>+

Please move the includes up so that they're instead right below the nsILoadContext.h include (nsIproperies.h include first). r=me with that fixed.
Attachment #8638926 - Flags: feedback?(stefanh) → review+
(Assignee)

Comment 4

3 years ago
Created attachment 8638964 [details] [diff] [review]
patch for checkin
Attachment #8638964 - Flags: review+
(Assignee)

Comment 5

3 years ago
Comment on attachment 8638964 [details] [diff] [review]
patch for checkin

Pushed to comm-central:
https://hg.mozilla.org/comm-central/rev/09d2d89fd95b
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
Target Milestone: --- → seamonkey2.39
You need to log in before you can comment on or make changes to this bug.