Handle proxies in mozAccessible focus, window, canBeFocused, isFocused

RESOLVED FIXED in Firefox 42

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: lsocks, Assigned: lsocks)

Tracking

unspecified
mozilla42
x86_64
macOS
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(3 attachments, 1 obsolete attachment)

Assignee

Description

4 years ago
No description provided.
Assignee

Comment 1

4 years ago
Assignee: nobody → lorien
Attachment #8638935 - Flags: review?(tbsaunde+mozbugs)
Assignee

Comment 2

4 years ago
Attachment #8638936 - Flags: review?(tbsaunde+mozbugs)
Attachment #8638936 - Flags: review?(tbsaunde+mozbugs) → review+
Attachment #8638935 - Flags: review?(tbsaunde+mozbugs) → review+
Assignee

Comment 3

4 years ago
Posted patch part 2 - window (obsolete) — Splinter Review
Attachment #8639034 - Flags: review?(tbsaunde+mozbugs)
Assignee

Updated

4 years ago
Summary: Handle proxies in mozAccessible focus, window, canBeFocused → Handle proxies in mozAccessible focus, window, canBeFocused, isFocused
Comment on attachment 8639034 [details] [diff] [review]
part 2 - window

>+    docAcc = accWrap->Document();
>+  }
>+  else if (ProxyAccessible* proxy = [self getProxyAccessible]) {

braces

>+    Accessible* outerDoc = proxy->OuterDocOfRemoteBrowser();
>+    if (outerDoc)
>+      docAcc = outerDoc->Document();
>+  }
>   if (docAcc)

blank line please

>     nativeWindow = static_cast<NSWindow*>(docAcc->GetNativeWindow());
> 
>   NSAssert1(nativeWindow, @"Could not get native window for %@", self);

unrelated, but that seems bogus
Attachment #8639034 - Flags: review?(tbsaunde+mozbugs) → review+
Assignee

Comment 5

4 years ago
carry r=tbsaunde
Attachment #8639034 - Attachment is obsolete: true
Attachment #8643068 - Flags: review+
You need to log in before you can comment on or make changes to this bug.