1187611 - Handle proxies in mozAccessible focus, window, canBeFocused, isFocused

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[Lorien Hu (:lsocks)]

Attachment: part 1 - focus

Comment 2

[Lorien Hu (:lsocks)]

Attachment: part 3 - canBeFocused

Comment 3

[Lorien Hu (:lsocks)]

Attachment: part 2 - window

Comment 4

[Trevor Saunders (:tbsaunde)]

Comment on attachment 8639034 [details] [diff] [review]
part 2 - window

>+    docAcc = accWrap->Document();
>+  }
>+  else if (ProxyAccessible* proxy = [self getProxyAccessible]) {

braces

>+    Accessible* outerDoc = proxy->OuterDocOfRemoteBrowser();
>+    if (outerDoc)
>+      docAcc = outerDoc->Document();
>+  }
>   if (docAcc)

blank line please

>     nativeWindow = static_cast<NSWindow*>(docAcc->GetNativeWindow());
> 
>   NSAssert1(nativeWindow, @"Could not get native window for %@", self);

unrelated, but that seems bogus

Comment 5

[Lorien Hu (:lsocks)]

Attachment: part 2 - fixed window

carry r=tbsaunde

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3cfa0ff6f2e5
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a9eabc1c121
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9580c329762

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3cfa0ff6f2e5
https://hg.mozilla.org/mozilla-central/rev/5a9eabc1c121
https://hg.mozilla.org/mozilla-central/rev/c9580c329762