Closed Bug 1187613 Opened 4 years ago Closed 4 years ago

Error: cannot initialize a variable of type 'const CGEventField' with an rvalue of type 'int' if build with 10.11 SDK

Categories

(Core :: Widget: Cocoa, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox42 --- fixed
firefox43 --- fixed
firefox-esr38 45+ fixed

People

(Reporter: Nomis101, Assigned: smichaud)

References

Details

Attachments

(1 file)

If I build FF/TB trunk on OS X 10.11 with the 10.11 SDK, it stops with the error:


/Developer/SDKs/MacOSX10.11.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSInputManager.h:20:1: note: 
      'insertText:' has been explicitly marked deprecated here
- (void) insertText:(null_unspecified id)aString NS_DEPRECATED_MAC(10_0...
^
/Volumes/Developer/mozilla-central/widget/cocoa/nsChildView.mm:6501:27: error: 
      cannot initialize a variable of type 'const CGEventField' with an rvalue
      of type 'int'
static const CGEventField kCGWindowNumberField = 51;
                          ^                      ~~


STR: Build with ac_add_options --with-macos-sdk=/Developer/SDKs/MacOSX10.11.sdk
Blocks: 1187975
Attached patch FixSplinter Review
This fixes the problem in my tests.
Assignee: nobody → smichaud
Status: NEW → ASSIGNED
Attachment #8658388 - Flags: review?(spohl.mozilla.bugs)
Attachment #8658388 - Flags: review?(spohl.mozilla.bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/9dc18f7a238f
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Comment on attachment 8658388 [details] [diff] [review]
Fix

Approval Request Comment
[Feature/regressing bug #]:1187613
[User impact if declined]: Can't compile release on 10.11 SDK
[Describe test coverage new/current, TreeHerder]: in aurora
[Risks and why]: none. This is a compilation fix only
[String/UUID change made/needed]: none
Attachment #8658388 - Flags: approval-mozilla-release?
Comment on attachment 8658388 [details] [diff] [review]
Fix

Sure
Attachment #8658388 - Flags: approval-mozilla-release? → approval-mozilla-release+
[Tracking Requested - why for this release]: FF38 ESR also hits this bug.
Comment on attachment 8658388 [details] [diff] [review]
Fix

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration:
User impact if declined: FF38-ESR will not build with latest MacOS SDK
Fix Landed on Version: 43
Risk to taking this patch (and alternatives if risky): Unknown
String or UUID changes made by this patch: 

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.
Attachment #8658388 - Flags: approval-mozilla-esr38?
Comment on attachment 8658388 [details] [diff] [review]
Fix

Seems safe, taking it.
Attachment #8658388 - Flags: approval-mozilla-esr38? → approval-mozilla-esr38+
You need to log in before you can comment on or make changes to this bug.