AUDIO alarms without attachments are rejected although valid

RESOLVED FIXED in 4.0.2

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Fallen, Assigned: Fallen)

Tracking

Trunk
4.0.2

Details

Attachments

(1 attachment)

The RFC mentions that AUDIO alarms can have an optional attachment, but our code expects there to always be an attachment. This causes modification failures on calendars that include such alarms. Example (valid):

BEGIN:VALARM
ACTION:AUDIO
TRIGGER;VALUE=DURATION:-P1D
END:VALARM
Summary: AUDIO alarms without attachments are not allowed → AUDIO alarms without attachments are rejected although valid
Posted patch Fix - v1 β€” β€” Splinter Review
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #8638987 - Flags: review?(mohit.kanwal)
Comment on attachment 8638987 [details] [diff] [review]
Fix - v1

Review of attachment 8638987 [details] [diff] [review]:
-----------------------------------------------------------------

Looks Good :D
Attachment #8638987 - Flags: review?(mohit.kanwal) → review+
Comment on attachment 8638987 [details] [diff] [review]
Fix - v1

This patch is fairly low risk and helps Rainlender users use their calendar. Therefore I will approve this for 4.0.2.
Attachment #8638987 - Flags: approval-calendar-release+
Attachment #8638987 - Flags: approval-calendar-beta+
Attachment #8638987 - Flags: approval-calendar-aurora+
Keywords: checkin-needed

Comment 4

4 years ago
https://hg.mozilla.org/comm-central/rev/54bb1dd1f272
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.4

Updated

4 years ago
Whiteboard: [aurora][beta][esr38]
url:        https://hg.mozilla.org/releases/comm-aurora/rev/0c4d96a60e8792dd4aa9bf516fcc52902367b350
changeset:  0c4d96a60e8792dd4aa9bf516fcc52902367b350
user:       Philipp Kewisch <mozilla@kewis.ch>
date:       Sun Jul 26 09:06:30 2015 +0200
description:
Bug 1187670 - AUDIO alarms without attachments are rejected although valid. r=redDragon
url:        https://hg.mozilla.org/releases/comm-beta/rev/53451ded1927849d96e2ee70f31a913ccea56bb6
changeset:  53451ded1927849d96e2ee70f31a913ccea56bb6
user:       Philipp Kewisch <mozilla@kewis.ch>
date:       Sun Jul 26 09:06:30 2015 +0200
description:
Bug 1187670 - AUDIO alarms without attachments are rejected although valid. r=redDragon
url:        https://hg.mozilla.org/releases/comm-esr38/rev/e6f40a8a53906a9b0cf152f54a6934441b993d4e
changeset:  e6f40a8a53906a9b0cf152f54a6934441b993d4e
user:       Philipp Kewisch <mozilla@kewis.ch>
date:       Sun Jul 26 09:06:30 2015 +0200
description:
Bug 1187670 - AUDIO alarms without attachments are rejected although valid. r=redDragon
Keywords: checkin-needed
Whiteboard: [aurora][beta][esr38]
Target Milestone: 4.4 → 4.0.2
You need to log in before you can comment on or make changes to this bug.