1187690 - No scene mode exposed in Camera app

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[:gerard-majax]

Looking at |app.camera.capabilities.sceneModes| values, we have much much much more mode supported compared to the current list (Normal/Panorama/Beauty):
  - auto
 - portrait
 - landscape
 - night
 - night-portrait
 - beach
 - snow
 - fireworks
 - sports
 - party
 - barcode
 - hdr
 - document
 - backlight
 - backlight-portrait
 - sweep-stitch
 - dark
 - dish
 - pet
 - baby
 - spot-light
 - soft-skin
 - anti-motion-blur
 - handheld-twilight
 - high-sensitivity

Wilson, any reason we do not expose all those to user ?

Comment 1

[:gerard-majax]

Attachment: Support Shinano Camera Scene modes

Comment 2

[:gerard-majax]

I have noticed something strange: changing those values from the Camera app setting menu does nothing. However, using the same keys values and directly calling the API from WebIDE: |app.camera.setSceneMode("auto");| does effectively change the preview image.

Testing values auto, fireworks and anti-motion-blur makes it quite obvious.

Comment 3

[Wilson Page [:wilsonpage]]

(In reply to Alexandre LISSY :gerard-majax from comment #2)
> I have noticed something strange: changing those values from the Camera app
> setting menu does nothing. However, using the same keys values and directly
> calling the API from WebIDE: |app.camera.setSceneMode("auto");| does
> effectively change the preview image.
> 
> Testing values auto, fireworks and anti-motion-blur makes it quite obvious.

You need to wire up the `change` events, so that when the scene is changed in the settings it is also changed on the camera hardware [1].

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/camera/js/controllers/camera.js#L88-L95

Comment 4

[Wilson Page [:wilsonpage]]

NI Tiff to give any necessary UX feedback.

Comment 5

[:gerard-majax]

I cannot find anything related to settings.scene?

Comment 6

[:gerard-majax]

Too cryptic for me for now, sorry, I cannot understand anything on how to wire this.

Comment 7

[:gerard-majax]

Attachment: Support Shinano Camera Scene modes

With plumbery.

Comment 8

[Wilson Page [:wilsonpage]]

Comment on attachment 8639873 [details] [diff] [review]
Support Shinano Camera Scene modes

Review of attachment 8639873 [details] [diff] [review]:
-----------------------------------------------------------------

There is a small complication here with HDR. HDR is actually a 'scene-mode', but our Camera UI exposes it as a separate setting. This means that when HDR is on we can't allow the user to choose a scene-mode. The best UX for this is to probably grey out the scene-mode setting when HDR is on. When HDR is switched off we must restore the last chosen scene-mode.

Comment 9

[Tiffanie Shakespeare [:tif]]

Hello! Sorry for the lengthy delay!

To Wilson's comment8 - It's not going to be super clear why scene mode is being disabled to the average person (HDR being on). I can see two options here: 
1) Put HDR into scene mode 
2) Implement the same strategy we use for flash and HDR - turning flash on turns off HDR automatically and turning HDR on turns of flash automatically.

#1 seems to be the easiest and seems to make the most sense. It actually isn't even adding a step as to toggle HDR on one would have to open the settings menu, tap on HDR, then tap on vs tap on Scene Mode, then tap HDR.

I'm having some issues getting hte patch onto my phone so a few questions:

1. Do scene modes apply to both photo and video modes or just photo (which is my assumption)? If only photo, we need to address the organization of the camera settings menu (distinguish between photo, video, and both settings) before pushing it to a release build.

2. Are the modes listed alphabetically?

3. What is the title to get into the sub-menu? 

Would it be possible to add this to developer settings, defaulted to off? This way it will make it into the foxfooding device and people can play with it, provide feedback, and can file bugs until UX gets a chance to address the issues mentioned. 

Thanks!

Comment 10

[:gerard-majax]

Why do you ask me ? I'm not working on this ?

Comment 11

[Tiffanie Shakespeare [:tif]]

Apologies - you were the original poster and the patch also has your name hence I Ni'd you. Thank you for NI'ing the correct person.

Comment 12

[Wilson Page [:wilsonpage]]

I don't have time to take this now, but I would like to add this feature. I think we should start to compile a list of Camera features that we would like to have for v3.0. Off the top of my head this would include:

- Aspect fit viewfinder
- Exposing picture/video resolution settings
- Scene mode
- Slow motion

Hema, Tiff, thoughts?

Comment 13

[Hema Koka [:hema]]

(In reply to Wilson Page [:wilsonpage] from comment #12)
> I don't have time to take this now, but I would like to add this feature. I
> think we should start to compile a list of Camera features that we would
> like to have for v3.0. Off the top of my head this would include:
> 
> - Aspect fit viewfinder
> - Exposing picture/video resolution settings
> - Scene mode
> - Slow motion
> 
> Hema, Tiff, thoughts?

Wilson,

There are quite a few low-hanging features that can be pulled up to the UI layer (some of them are already exposed in gecko). We have a gap analysis documented here, lets add missing ones to this and bring this into 3.0 planning for camera: https://docs.google.com/a/mozilla.com/spreadsheets/d/11EISxfn583z23lZH3-1RmRLTt-CEOlzO1hOeWSdKx5E/edit?usp=sharing

Thanks
Hema

Comment 14

[Tiffanie Shakespeare [:tif]]

It's been so long since I've thought about it...

I remember we wanted to replace the preview with actual Gallery. Justindarc and I have been working on (it's stalled though) a QR code reader add-on. 

We could add in a time-lapse feature or tilt-shift or other filters.

Comment 15

[:gerard-majax]

Attachment: Support Shinano Camera Scene modes

Comment 16

[:gerard-majax]

Attachment: Support Shinano Camera Scene modes

Comment 17

[BMO Automation]

Firefox OS is not being worked on