1187705 - Control center subview black and white arrow icons don't have the same size

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Tim Nguyen :ntim]

The white icon (the one that is shown when a subview is entered) seems smaller than the black icon (the default one).

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Oh, arrow icons. Yes, they are in fact different icons. We should probably add a proper black arrow icon instead of borrowing that from the main menu.

Comment 2

[Stephen Horlander [:shorlander]]

I think the CC arrow is SVG? Could dupe it and change the color to #fff.

Comment 3

[Stephen Horlander [:shorlander]]

(In reply to Stephen Horlander [:shorlander] from comment #2)
> I think the CC arrow is SVG? Could dupe it and change the color to #fff.

Forgot the "and flip it" part. :)

Comment 4

[Stephen Horlander [:shorlander]]

Attachment: arrow-subview-back-white.svg

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

You're a magician, Stephen.

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-1187705-Add-proper-white-arrow-to-show-when-subv.patch

Comment 7

[:Paolo Amadini]

Comment on attachment 8639899 [details] [diff] [review]
0001-Bug-1187705-Add-proper-white-arrow-to-show-when-subv.patch

I've not applied this locally so I could review this today, but the patch looks good!

As an aside, I seem to remember you can actually use styles like "color: HighlightText;" inside an SVG file if you want to use platform colors. So having this image as an SVG may actually simplify the other bugs about using platform colors.

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

(In reply to :Paolo Amadini from comment #7)
> As an aside, I seem to remember you can actually use styles like "color:
> HighlightText;" inside an SVG file if you want to use platform colors. So
> having this image as an SVG may actually simplify the other bugs about using
> platform colors.

That color:HightlightText rule was left over, it doesn't actually do anything. I think it was left over from bug 1181978 where it was introduced although we have no text on that button.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/4287f97ac668

Comment 10

[:Paolo Amadini]

(In reply to Tim Taubert [:ttaubert] from comment #8)
> That color:HightlightText rule was left over, it doesn't actually do
> anything. I think it was left over from bug 1181978 where it was introduced
> although we have no text on that button.

Yeah, I supposed that wouldn't take effect anyways. I was just saying that (if I remember correctly) color codes like HighlightText can be used inside the SVG to use system color themes (and would take effect, contrarily to the leftover rule obviously).

Comment 11

[Tim Taubert [:ttaubert] (inactive)]

Oh, yes. I think I saw it in some SVG recently, not sure where...

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4287f97ac668

Comment 13

[Catalin Varga [QA][:VarCat]]

Verified as fixed using the following environment:

FF 42
Build Id: 20150802030218
OS: Win 7 x64, Mac Os X 10.10, Ubuntu 12.04 x86