Closed Bug 1187705 Opened 4 years ago Closed 4 years ago

Control center subview black and white arrow icons don't have the same size

Categories

(Firefox :: Theme, defect, P1)

defect
Points:
2

Tracking

()

VERIFIED FIXED
Firefox 42
Iteration:
42.3 - Aug 10
Tracking Status
firefox41 --- affected
firefox42 --- verified

People

(Reporter: ntim, Assigned: ttaubert)

References

Details

(Whiteboard: [fxprivacy] [campaign])

Attachments

(2 files)

The white icon (the one that is shown when a subview is entered) seems smaller than the black icon (the default one).
Blocks: 1170759
Flags: firefox-backlog?
Whiteboard: [fxprivacy]
Summary: Control center subview black and white icons don't have the same size → Control center subview black and white arrow icons don't have the same size
Oh, arrow icons. Yes, they are in fact different icons. We should probably add a proper black arrow icon instead of borrowing that from the main menu.
Points: --- → 2
I think the CC arrow is SVG? Could dupe it and change the color to #fff.
(In reply to Stephen Horlander [:shorlander] from comment #2)
> I think the CC arrow is SVG? Could dupe it and change the color to #fff.

Forgot the "and flip it" part. :)
You're a magician, Stephen.
Flags: qe-verify?
Flags: firefox-backlog?
Flags: firefox-backlog+
Priority: -- → P2
Flags: qe-verify? → qe-verify+
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Iteration: --- → 42.3 - Aug 10
Priority: P2 → P1
QA Contact: mwobensmith
Whiteboard: [fxprivacy] → [fxprivacy] [campaign]
Comment on attachment 8639899 [details] [diff] [review]
0001-Bug-1187705-Add-proper-white-arrow-to-show-when-subv.patch

I've not applied this locally so I could review this today, but the patch looks good!

As an aside, I seem to remember you can actually use styles like "color: HighlightText;" inside an SVG file if you want to use platform colors. So having this image as an SVG may actually simplify the other bugs about using platform colors.
Attachment #8639899 - Flags: review?(paolo.mozmail) → review+
(In reply to :Paolo Amadini from comment #7)
> As an aside, I seem to remember you can actually use styles like "color:
> HighlightText;" inside an SVG file if you want to use platform colors. So
> having this image as an SVG may actually simplify the other bugs about using
> platform colors.

That color:HightlightText rule was left over, it doesn't actually do anything. I think it was left over from bug 1181978 where it was introduced although we have no text on that button.
(In reply to Tim Taubert [:ttaubert] from comment #8)
> That color:HightlightText rule was left over, it doesn't actually do
> anything. I think it was left over from bug 1181978 where it was introduced
> although we have no text on that button.

Yeah, I supposed that wouldn't take effect anyways. I was just saying that (if I remember correctly) color codes like HighlightText can be used inside the SVG to use system color themes (and would take effect, contrarily to the leftover rule obviously).
Oh, yes. I think I saw it in some SVG recently, not sure where...
https://hg.mozilla.org/mozilla-central/rev/4287f97ac668
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Verified as fixed using the following environment:

FF 42
Build Id: 20150802030218
OS: Win 7 x64, Mac Os X 10.10, Ubuntu 12.04 x86
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.