Closed Bug 1187711 Opened 7 years ago Closed 7 years ago
Enable -Wshadow in Dom::Security
40 bytes, text/x-review-board-request
As suggested in this thread on dev-platform: https://groups.google.com/d/msg/mozilla.dev.platform/-cDq6DqBZ2k/mgh0MWcSd6gJ it would be good if we had -Wshadow enabled throughout the code. All of the code under dom/security currently builds fine with it.
Bug 1187711 - Enable -Wshadow in DOM::Security. r?ckerschb
Attachment #8639039 - Flags: review?(mozilla)
Assignee: nobody → francois
Status: NEW → ASSIGNED
https://reviewboard.mozilla.org/r/14159/#review12755 ::: dom/security/moz.build:41 (Diff revision 1) > +CXXFLAGS += ['-Wshadow'] /layout is already using it - go for it! Thanks!
Comment on attachment 8639039 [details] MozReview Request: Bug 1187711 - Enable -Wshadow in DOM::Security. r?ckerschb https://reviewboard.mozilla.org/r/14161/#review12757 Ship It!
Attachment #8639039 - Flags: review?(mozilla) → review+
You need to log in before you can comment on or make changes to this bug.