Closed
Bug 1187711
Opened 9 years ago
Closed 9 years ago
Enable -Wshadow in Dom::Security
Categories
(Core :: DOM: Security, defect)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: francois, Assigned: francois)
References
Details
Attachments
(1 file)
As suggested in this thread on dev-platform: https://groups.google.com/d/msg/mozilla.dev.platform/-cDq6DqBZ2k/mgh0MWcSd6gJ it would be good if we had -Wshadow enabled throughout the code. All of the code under dom/security currently builds fine with it.
Assignee | ||
Comment 1•9 years ago
|
||
Bug 1187711 - Enable -Wshadow in DOM::Security. r?ckerschb
Attachment #8639039 -
Flags: review?(mozilla)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → francois
Status: NEW → ASSIGNED
Comment 2•9 years ago
|
||
https://reviewboard.mozilla.org/r/14159/#review12755 ::: dom/security/moz.build:41 (Diff revision 1) > +CXXFLAGS += ['-Wshadow'] /layout is already using it - go for it! Thanks!
Comment 3•9 years ago
|
||
Comment on attachment 8639039 [details] MozReview Request: Bug 1187711 - Enable -Wshadow in DOM::Security. r?ckerschb https://reviewboard.mozilla.org/r/14161/#review12757 Ship It!
Attachment #8639039 -
Flags: review?(mozilla) → review+
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/318399e74742 https://hg.mozilla.org/mozilla-central/rev/8b610e923049
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•