1187711 - Enable -Wshadow in Dom::Security

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Description

[François Marier [:francois]]

As suggested in this thread on dev-platform:

  https://groups.google.com/d/msg/mozilla.dev.platform/-cDq6DqBZ2k/mgh0MWcSd6gJ

it would be good if we had -Wshadow enabled throughout the code.

All of the code under dom/security currently builds fine with it.

Comment 1

[François Marier [:francois]]

Attachment: MozReview Request: Bug 1187711 - Enable -Wshadow in DOM::Security. r?ckerschb

Bug 1187711 - Enable -Wshadow in DOM::Security. r?ckerschb

Comment 2

[Christoph Kerschbaumer [:ckerschb}]

https://reviewboard.mozilla.org/r/14159/#review12755

::: dom/security/moz.build:41
(Diff revision 1)
> +CXXFLAGS += ['-Wshadow']

/layout is already using it - go for it! Thanks!

Comment 3

[Christoph Kerschbaumer [:ckerschb}]

Comment on attachment 8639039 [details]
MozReview Request: Bug 1187711 - Enable -Wshadow in DOM::Security. r?ckerschb

https://reviewboard.mozilla.org/r/14161/#review12757

Ship It!

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/318399e74742

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8b610e923049

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/318399e74742
https://hg.mozilla.org/mozilla-central/rev/8b610e923049