Last Comment Bug 1187728 - There are still calendar-windows css files referenced
: There are still calendar-windows css files referenced
Status: RESOLVED FIXED
:
Product: Calendar
Classification: Client Software
Component: General (show other bugs)
: Lightning 4.4
: Unspecified Windows
-- minor (vote)
: 4.4
Assigned To: Richard Marti (:Paenglab)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2015-07-26 12:35 PDT by [:MakeMyDay]
Modified: 2015-08-07 03:11 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
1187728.patch (2.42 KB, patch)
2015-07-26 13:30 PDT, Richard Marti (:Paenglab)
makemyday: review+
Details | Diff | Splinter Review

Description User image [:MakeMyDay] 2015-07-26 12:35:52 PDT
From the error console in current Daily on Windows:

No chrome package registered for chrome://calendar-windows/skin/lightning.css
No chrome package registered for chrome://calendar-windows/skin/lightning.css
No chrome package registered for chrome://calendar-windows/skin/lightning-toolbar.css
No chrome package registered for chrome://calendar-windows/skin/lightning-toolbar.css
No chrome package registered for chrome://calendar-windows/skin/calendar.css
No chrome package registered for chrome://calendar-windows/skin/calendar.css

This seems to be a leftover of bug 1172582, there are still three occurences related to calendar-windows in the tree [1].

Richard, I'm not sure whether they should just be removed or refer to the respective common file instead. Can you take a look at it?


[1] http://mxr.mozilla.org/comm-central/search?string=calendar-windows&find=%2Fcalendar%2F&findi=&filter=%5E%5B%5E%5C0%5D*%24&hitlimit=&tree=comm-central
Comment 1 User image Richard Marti (:Paenglab) 2015-07-26 13:30:52 PDT
Created attachment 8639057 [details] [diff] [review]
1187728.patch

Thank you for pointing to them. They can be removed without any further pointing.
Comment 2 User image [:MakeMyDay] 2015-07-26 13:55:16 PDT
Comment on attachment 8639057 [details] [diff] [review]
1187728.patch

Review of attachment 8639057 [details] [diff] [review]:
-----------------------------------------------------------------

r+, thanks for the quick patch.

Note You need to log in before you can comment on or make changes to this bug.