Closed Bug 1187728 Opened 5 years ago Closed 5 years ago

There are still calendar-windows css files referenced

Categories

(Calendar :: General, defect, minor)

Lightning 4.4
Unspecified
Windows
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: MakeMyDay, Assigned: Paenglab)

Details

Attachments

(1 file)

From the error console in current Daily on Windows:

No chrome package registered for chrome://calendar-windows/skin/lightning.css
No chrome package registered for chrome://calendar-windows/skin/lightning.css
No chrome package registered for chrome://calendar-windows/skin/lightning-toolbar.css
No chrome package registered for chrome://calendar-windows/skin/lightning-toolbar.css
No chrome package registered for chrome://calendar-windows/skin/calendar.css
No chrome package registered for chrome://calendar-windows/skin/calendar.css

This seems to be a leftover of bug 1172582, there are still three occurences related to calendar-windows in the tree [1].

Richard, I'm not sure whether they should just be removed or refer to the respective common file instead. Can you take a look at it?


[1] http://mxr.mozilla.org/comm-central/search?string=calendar-windows&find=%2Fcalendar%2F&findi=&filter=%5E%5B%5E%5C0%5D*%24&hitlimit=&tree=comm-central
Attached patch 1187728.patchSplinter Review
Thank you for pointing to them. They can be removed without any further pointing.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8639057 - Flags: review?(makemyday)
Comment on attachment 8639057 [details] [diff] [review]
1187728.patch

Review of attachment 8639057 [details] [diff] [review]:
-----------------------------------------------------------------

r+, thanks for the quick patch.
Attachment #8639057 - Flags: review?(makemyday) → review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/4f7ee254c923
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 4.4
You need to log in before you can comment on or make changes to this bug.