1187734 - Replace jquery-thead with something maintained

Status: RESOLVED FIXED

(Webtools Graveyard :: Elmo, defect)

Description

[Axel Hecht [:Pike]]

For the team page, we have table headers that stay visible.

Currently, this uses https://github.com/asual/jquery-thead, but that hasn't been updated since 2011, and needs jquery migration to still work.

https://github.com/jmosbech/StickyTableHeaders is maintained, works just as well as far as I can tell, so let's convert.

Comment 1

[[github robot]]

Commit pushed to develop at https://github.com/mozilla/elmo

https://github.com/mozilla/elmo/commit/a1709c6fb4b12f2d1d8cd665efcbbe8c02a11794
bug 1187734, switch from jquery.thead to StickyTableHeaders

jquery.thead was last changed in 2011, and required jquery-migrate.
StickTableHeaders is fresh.

Source from https://github.com/jmosbech/StickyTableHeaders, 0.1.17

Comment 2

[[github robot]]

Commit pushed to develop at https://github.com/mozilla/elmo

https://github.com/mozilla/elmo/commit/7b7dab7b218ce73308ba3ff410ac3dfb909d25a3
Revert "bug 1187734, switch from jquery.thead to StickyTableHeaders"

This reverts commit a1709c6fb4b12f2d1d8cd665efcbbe8c02a11794.

StickyTableHeaders sadly has perf problems.

Comment 3

[Axel Hecht [:Pike]]

I had to back this out, sadly. Perf was bad.

Comment 4

[Axel Hecht [:Pike]]

position: sticky is supported. Deal.

https://github.com/mozilla/elmo/commit/f5cef5e2620002147633a829ac091c1621ec2c58 landed on stage.

There's one minor regression, and that's table head borders don't work in Firefox with position:sticky. Filed bug 1531781.

It doesn't work on Chrome at all, no idea why.