Closed
Bug 1187767
Opened 9 years ago
Closed 9 years ago
Ensure PLDHashTable's generation is always updated when the entry store is modified
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(1 file)
15.95 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
Ever since I changed PLDHashTable to initialize its entry store lazily, there have been some corner cases where |mEntryStore| can be updated while |mGeneration| is not, e.g. when the first element is added and |mEntryStore| goes from nullptr to non-nullptr. These cases *probably* don't come up in practice, but it seems worth making this more fool-proof just in case.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8639105 -
Flags: review?(nfroyd)
Comment 2•9 years ago
|
||
Comment on attachment 8639105 [details] [diff] [review] Ensure PLDHashTable's generation is always updated when the entry store is modified Review of attachment 8639105 [details] [diff] [review]: ----------------------------------------------------------------- Nice.
Attachment #8639105 -
Flags: review?(nfroyd) → review+
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/45ad89111683
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•