Closed Bug 1187767 Opened 9 years ago Closed 9 years ago

Ensure PLDHashTable's generation is always updated when the entry store is modified

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

Attachments

(1 file)

Ever since I changed PLDHashTable to initialize its entry store lazily, there
have been some corner cases where |mEntryStore| can be updated while
|mGeneration| is not, e.g. when the first element is added and |mEntryStore|
goes from nullptr to non-nullptr.

These cases *probably* don't come up in practice, but it seems worth making
this more fool-proof just in case.
Comment on attachment 8639105 [details] [diff] [review]
Ensure PLDHashTable's generation is always updated when the entry store is modified

Review of attachment 8639105 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.
Attachment #8639105 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/45ad89111683
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: