Closed Bug 1187791 Opened 4 years ago Closed 4 years ago
Recognition::max Alternatives can't throw; so, rm webidl throws specifier
As a result of the implementation of SpeechRecognition::maxAlternatives in Bug 1185235, SpeechRecognition::maxAlternatives can't throw. Thus, there is no need for the webidl "throws specifier" to be on the attribute SpeechRecognition::maxAlternatives in SpeechRecognition.webidl. The task of this bug is to remove this webidl "throws specifier" and make the associated changes in the C++ classes.
Assignee: nobody → kdavis
Part 1 of 1: SpeechRecognition::maxAlternatives can't throw; so, rm webidl throws specifier Part 1 of 1 for this bug. This patch removes the throw specifier from the wedidl for the attribute SpeechRecognition::maxAlternatives, as the implementation of this attribute can not run into an error condition, and makes the associated changes in the C++ code. The try for this patch is here https://treeherder.mozilla.org/#/jobs?repo=try&revision=49a132dff8e7
Attachment #8639684 - Flags: review?(bugs)
Hi, this failed to apply: renamed 1187791 -> 0001-Bug-1187791-Part-1-of-1-SpeechRecognition-maxAlterna.patch applying 0001-Bug-1187791-Part-1-of-1-SpeechRecognition-maxAlterna.patch patching file dom/media/webspeech/recognition/SpeechRecognition.cpp Hunk #1 succeeded at 681 with fuzz 2 (offset 0 lines). patching file dom/media/webspeech/recognition/SpeechRecognition.h Hunk #1 FAILED at 80 1 out of 1 hunks FAILED -- saving rejects to file dom/media/webspeech/recognition/SpeechRecognition.h.rej patching file dom/webidl/SpeechRecognition.webidl Hunk #1 FAILED at 17 1 out of 1 hunks FAILED -- saving rejects to file dom/webidl/SpeechRecognition.webidl.rej patch failed, unable to continue (try -v) patch failed, rejects left in working directory errors during apply, please fix and refresh 0001-Bug-1187791-Part-1-of-1-SpeechRecognition-maxAlterna.patch
Part 1 of 1: SpeechRecognition::maxAlternatives can't throw; so, rm webidl throws specifier Part 1 of 1 for this bug. This patch makes no changes relative to the one is it obsoletes. It is simply based off a rebase of the the most recent inbound/branches/default/tip.
You need to log in before you can comment on or make changes to this bug.