Update bedrock version of waypoints.js

RESOLVED FIXED

Status

www.mozilla.org
Pages & Content
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: agibson, Assigned: jpetto)

Tracking

Production

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [kb=1808655])

Attachments

(1 attachment)

44 bytes, text/x-github-pull-request
Details | Review | Splinter Review
(Reporter)

Description

3 years ago
One of our most commonly used third parts JS libs for scrolling is called Waypoints. The version we have in bedrock is now pretty old [1], [2]. The latest version of Waypoints.js [3] no longer has jQuery as a dependency. As such, the version we are currently using is not compatible with the latest version of jQuery (and never will be). So, we should look to update our code to use the current version. 

[1] https://github.com/mozilla/bedrock/blob/master/media/js/libs/jquery.waypoints.min.js
[2] https://github.com/mozilla/bedrock/blob/master/media/js/libs/jquery.waypoints-sticky.min.js
[3] https://github.com/imakewebthings/waypoints
(Reporter)

Updated

3 years ago
Whiteboard: [kb=1808655]
(Reporter)

Comment 1

3 years ago
Latest Waypoints release can be downloaded here: https://github.com/imakewebthings/waypoints/releases/tag/latest
(Assignee)

Updated

3 years ago
Assignee: nobody → jon
(Assignee)

Comment 2

3 years ago
Created attachment 8649898 [details] [review]
GitHub PR
(Assignee)

Comment 3

3 years ago
The 'sticky' Waypoints plugin *does* require the jQuery build of Waypoints, so that build has been included in the PR.

Comment 4

3 years ago
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/e32ac3614bf620a7492df3271e1142c002398b30
[fix bug 1187829] Update waypoints JS lib.

- Remove orphaned 'products' bundle & JS file.

https://github.com/mozilla/bedrock/commit/0e918956a6cd3a2cc29ed166e1c443ed5cc3b01f
Merge pull request #3224 from jpetto/bug-1187829-update-waypoints-script

[fix bug 1187829] Update waypoints JS lib.

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Comment 5

3 years ago
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/fc3cef9559e7cd812370433d709e176d573e745f
[bug 1187829] Update Waypoint JS trigger on australis page

https://github.com/mozilla/bedrock/commit/5f60253dd2c97e60a219a18a7b653b77b594a4a7
Merge pull request #3234 from alexgibson/bug-1187829-update-waypoint-australis-page

[bug 1187829] Update Waypoint JS trigger on australis page
You need to log in before you can comment on or make changes to this bug.