1187836 - [RTL][Bluetooth]With device language in Arabic, the Parentheses of the device name displays abnormal in "Paired devices" or "Devices in the Area" lis

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[SandKing]

Attachment: Aries_v2.5.png

[1.Description]:
[RTL][Aries v2.5][Flame v2.2&master][Bluetooth]With device language in Arabic, The Parentheses  display abnormally  in "Paired devices" or  "Devices in the Area" list,  for example  "Flame(B2G)" changes to  "(Flame (B2G"
See picture:"Aries_v2.2.png"

[2.Testing Steps]: 
Precondition: The system language is "Arabic". and have a device B( part of its name is parentheses-enclosed[Ex: "Flame(B2G)"].
1. Launch "Settings"->"Bluetooth"
2. Enable "Bluetooth"
3. Make the device B to be listed in "Paired devices" or  "Devices in the Area".


[3.Expected Result]: 
3.  The Parentheses should display normally 

[4.Actual Result]: 
3. The Parentheses display abnormally  in "Paired devices" or  "Devices in the Area" list

[5.Reproduction build]: 
Aries v2.5 version (Affected)
Build ID               20150723024716
Gaia Revision          f04fdbfa1943dddeab8ecd1299a76ab56e590d00
Gaia Date              2015-07-22 18:44:09
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/2ddec2dedced
Gecko Version          42.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150723.023231
Firmware Date          Thu Jul 23 02:32:39 UTC 2015
Bootloader             s1

Flame 2.2 version (Affected)
Build ID               20150726002502
Gaia Revision          e1e6317f17a840b19af9dbb25f5a771d8d9fa161
Gaia Date              2015-07-15 21:05:11
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/551aee22a380
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150726.041648
Firmware Date          Sun Jul 26 04:16:59 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Flame master version (Affected)
Build ID               20150726160205
Gaia Revision          ade1ef5249cfab921e00ed67b30f3d03c2e24b5e
Gaia Date              2015-07-24 11:53:36
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/d3228c82badd
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150726.191858
Firmware Date          Sun Jul 26 19:19:10 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
15665

Comment 1

[[e-mail]]

Zibi, we see a bunch of RTL (parentheses) issue, does it related to l10n, or do you have any idea to deal with that?

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Yeah. So, here: https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/elements/bluetooth_v2.html#L36-L37

you inject <span>Flame(B2G)</span>. Instead use <bdi>Flame(B2G)</bdi>.


Overall, wherever you have a string that may have its own directionality, use <bdi> instead of <span>.

Comment 3

[Ahmed Nefzaoui [:Nefzaoui]]

(In reply to Zibi Braniecki [:gandalf][:zibi] from comment #2)
> Overall, wherever you have a string that may have its own directionality,
> use <bdi> instead of <span>.

Correct, however there are different (and better) ways to do it, not necessarily touching the DOM.
However, let's not waste time fixing any of those bugs for the time being. Because when RTL work kicks off, it will be a work from the ground up, which means practically all of those little fixes will be gone.

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Fred, we discussed it with Ahmed on IRC. Go with the <bdi> approach.

Comment 5

[[e-mail]]

Thanks!

Comment 6

[[e-mail]]

Attachment: bdi.png

after patch

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] gasolin:issue-1187836 > mozilla-b2g:master

Comment 8

[[e-mail]]

Comment on attachment 8639700 [details] [review]
[gaia] gasolin:issue-1187836 > mozilla-b2g:master

Need a stamp

Comment 9

[Evelyn Hung]

Comment on attachment 8639700 [details] [review]
[gaia] gasolin:issue-1187836 > mozilla-b2g:master

Thanks.

Comment 10

[[e-mail]]

merged to master https://github.com/mozilla-b2g/gaia/commit/0a47ebb914a25fa779fe40a5fe77c33cd230ea11

thanks!

Comment 11

[Annabelle]

Attachment: Verified_Flame_2.5.png

This bug has been verified as "pass" on latest nightly build of  Flame v2.5 and Nexus5 v2.5 by the STR in Comment 0.

Actual results: The Parentheses display normally after the device B be listed in "Paired devices" or  "Devices in the Area".

Reproduce rate: 0/10 
See attachment : Verified_Flame_v2.5.png

Device: Flame KK 2.5 build(Pass)
Build ID               20150730150205
Gaia Revision          7e7e92fbeea90cad8bf6f494b1a73712f79178e8
Gaia Date              2015-07-30 17:03:31
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/23e525e2ba35
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150730.183847
Firmware Date          Thu Jul 30 18:38:56 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Nexus5 v2.5(pass)
Build ID               20150730150205
Gaia Revision          7e7e92fbeea90cad8bf6f494b1a73712f79178e8
Gaia Date              2015-07-30 17:03:31
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/23e525e2ba35
Gecko Version          42.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150730.183055
Firmware Date          Thu Jul 30 18:31:09 EDT 2015
Bootloader             HHZ12f

Comment 12

[Annabelle]

Attachment: verified_Aries v2.5.png

According to the STR of Comment 0, this bug has been verified as pass on latest Nightly Aries KK v2.5.

Actual results: The Parentheses display normally in "Paired devices" or  "Devices in the Area" list
See attachment: verified_Aries v2.5.png
Reproduce rate: 0/6

Device: Aries KK 2.5(pass)
Build ID               20150730224606
Gaia Revision          7e7e92fbeea90cad8bf6f494b1a73712f79178e8
Gaia Date              2015-07-30 17:03:31
Gecko Revision         https://hg.mozilla.org/integration/b2g-inbound/rev/888e8026ed60
Gecko Version          42.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150730.223725
Firmware Date          Thu Jul 30 22:37:33 UTC 2015
Bootloader             s1

Comment 13

[SandKing]

Leave "Resolved" until v2.2 is fixed.