Closed Bug 1187872 Opened 5 years ago Closed 5 years ago

Remove HAL backend from Bluetooth

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

(firefox42 fixed)

RESOLVED FIXED
Tracking Status
firefox42 --- fixed

People

(Reporter: tzimmermann, Assigned: tzimmermann)

Details

Attachments

(1 file)

Bluetooth's HAL backend has been superseded by the Bluetooth daemon and is not used in our recent version v2.2.

This bug is for removing the HAL backend from m-c.
Hi!

is there anything in HAL that can not be done with the daemon?
Flags: needinfo?(shuang)
Flags: needinfo?(joliu)
Flags: needinfo?(btian)
Flags: needinfo?(brsun)
Supposedly the answer is no for GATT part.

ni? Jamin as well for other parts (ex. PBAP and MAP).
Flags: needinfo?(brsun) → needinfo?(jaliu)
(In reply to Bruce Sun [:brsun] from comment #2)
> Supposedly the answer is no for GATT part.
> 
> ni? Jamin as well for other parts (ex. PBAP and MAP).

Daemon works with PBAP and MAP since they utilize bluetooth socket as OPP.

I'm fine to remove HAL.
Flags: needinfo?(jaliu)
Flags: needinfo?(btian)
I don't see any reason to keep HAL currently, let's remove it since GATT server daemon already implemented.
Flags: needinfo?(shuang)
None from my end, thanks.
Flags: needinfo?(joliu)
Great! :D Removes over 8000 lines of code. I've been looking forward to this patch.
Attachment #8639877 - Flags: review?(shuang)
Comment on attachment 8639877 [details] [diff] [review]
[01] Bug 1187872: Remove HAL backend from Bluetooth

Review of attachment 8639877 [details] [diff] [review]:
-----------------------------------------------------------------

Assassin: BluetoothHALInterface must die. Thanks for cleanup.
Attachment #8639877 - Flags: review?(shuang) → review+
This built locally without touching CLOBBER. Let's hope it does on m-c as well.

https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=293dd17693db
https://hg.mozilla.org/mozilla-central/rev/293dd17693db
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.