1187872 - Remove HAL backend from Bluetooth

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Bluetooth's HAL backend has been superseded by the Bluetooth daemon and is not used in our recent version v2.2.

This bug is for removing the HAL backend from m-c.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Hi!

is there anything in HAL that can not be done with the daemon?

Comment 2

[Bruce Sun [:brsun]]

Supposedly the answer is no for GATT part.

ni? Jamin as well for other parts (ex. PBAP and MAP).

Comment 3

[Ben Tian (inactive)]

(In reply to Bruce Sun [:brsun] from comment #2)
> Supposedly the answer is no for GATT part.
> 
> ni? Jamin as well for other parts (ex. PBAP and MAP).

Daemon works with PBAP and MAP since they utilize bluetooth socket as OPP.

I'm fine to remove HAL.

Comment 4

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

I don't see any reason to keep HAL currently, let's remove it since GATT server daemon already implemented.

Comment 5

[Jocelyn Liu [:jocelyn] [:joliu]]

None from my end, thanks.

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1187872: Remove HAL backend from Bluetooth

Great! :D Removes over 8000 lines of code. I've been looking forward to this patch.

Comment 7

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Comment on attachment 8639877 [details] [diff] [review]
[01] Bug 1187872: Remove HAL backend from Bluetooth

Review of attachment 8639877 [details] [diff] [review]:
-----------------------------------------------------------------

Assassin: BluetoothHALInterface must die. Thanks for cleanup.

Comment 8

[Thomas Zimmermann [:tzimmermann] [:tdz]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=535a65ab4e21

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/293dd17693db

Comment 10

[Thomas Zimmermann [:tzimmermann] [:tdz]]

This built locally without touching CLOBBER. Let's hope it does on m-c as well.

https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=293dd17693db

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/293dd17693db