Closed Bug 1187904 Opened 5 years ago Closed 5 years ago

Move |BluetoothDaemonConnector| to ipc/hal

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(firefox42 fixed)

RESOLVED FIXED
FxOS-S4 (07Aug)
Tracking Status
firefox42 --- fixed

People

(Reporter: tzimmermann, Assigned: tzimmermann)

References

Details

Attachments

(3 files, 3 obsolete files)

|BluetoothDaemonConnector| is not specific to Bluetooth, so it should be located in ipc/hal.
Changes since v1:

  - remove BluetoothDaemonConnector.cpp
Attachment #8639292 - Attachment is obsolete: true
Attachment #8639290 - Flags: review?(shuang)
Attachment #8639291 - Flags: review?(shuang)
Attachment #8639299 - Flags: review?(shuang)
Comment on attachment 8639290 [details] [diff] [review]
[01] Bug 1187904: Add |DaemonSocketConnector|

Review of attachment 8639290 [details] [diff] [review]:
-----------------------------------------------------------------

::: ipc/hal/DaemonSocketConnector.cpp
@@ +51,5 @@
> +  aAddress = aPrefix;
> +  aAddress.Append('-');
> +
> +  while (aPostfixLength) {
> +

nit: Remove this line.
Attachment #8639290 - Flags: review?(shuang) → review+
Changes since v1:

  - updated coding style according to review
Attachment #8639290 - Attachment is obsolete: true
Attachment #8641564 - Flags: review+
Changes since v2:

  - rebased onto m-c
Attachment #8639299 - Attachment is obsolete: true
Attachment #8641565 - Flags: review+
You need to log in before you can comment on or make changes to this bug.