1187904 - Move |BluetoothDaemonConnector| to ipc/hal

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

|BluetoothDaemonConnector| is not specific to Bluetooth, so it should be located in ipc/hal.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1187904: Add |DaemonSocketConnector|

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [02] Bug 1187904: Convert |BluetoothDaemonInterface| to use |DaemonSocketConnector|

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [03] Bug 1187904: Remove |BluetoothDaemonConnector| and random-address creator

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1af875191a29

Comment 5

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [03] Bug 1187904: Remove |BluetoothDaemonConnector| and random-address creator (v2)

Changes since v1:

  - remove BluetoothDaemonConnector.cpp

Comment 6

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Comment on attachment 8639290 [details] [diff] [review]
[01] Bug 1187904: Add |DaemonSocketConnector|

Review of attachment 8639290 [details] [diff] [review]:
-----------------------------------------------------------------

::: ipc/hal/DaemonSocketConnector.cpp
@@ +51,5 @@
> +  aAddress = aPrefix;
> +  aAddress.Append('-');
> +
> +  while (aPostfixLength) {
> +

nit: Remove this line.

Comment 7

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1187904: Add |DaemonSocketConnector| (v2)

Changes since v1:

  - updated coding style according to review

Comment 8

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [03] Bug 1187904: Remove |BluetoothDaemonConnector| and random-address creator (v3)

Changes since v2:

  - rebased onto m-c

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/bf83fb8e2edf
https://hg.mozilla.org/integration/b2g-inbound/rev/911af3f44bbc
https://hg.mozilla.org/integration/b2g-inbound/rev/30d6aae8ad3a

Comment 10

[Thomas Zimmermann [:tzimmermann] [:tdz]]

https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=30d6aae8ad3a

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bf83fb8e2edf
https://hg.mozilla.org/mozilla-central/rev/911af3f44bbc
https://hg.mozilla.org/mozilla-central/rev/30d6aae8ad3a