Move |BluetoothDaemonConnector| to ipc/hal

RESOLVED FIXED in Firefox 42

Status

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: tzimmermann, Assigned: tzimmermann)

Tracking

unspecified
FxOS-S4 (07Aug)
All
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(3 attachments, 3 obsolete attachments)

|BluetoothDaemonConnector| is not specific to Bluetooth, so it should be located in ipc/hal.
Changes since v1:

  - remove BluetoothDaemonConnector.cpp
Attachment #8639292 - Attachment is obsolete: true
Attachment #8639290 - Flags: review?(shuang)
Attachment #8639291 - Flags: review?(shuang)
Attachment #8639299 - Flags: review?(shuang)
Comment on attachment 8639290 [details] [diff] [review]
[01] Bug 1187904: Add |DaemonSocketConnector|

Review of attachment 8639290 [details] [diff] [review]:
-----------------------------------------------------------------

::: ipc/hal/DaemonSocketConnector.cpp
@@ +51,5 @@
> +  aAddress = aPrefix;
> +  aAddress.Append('-');
> +
> +  while (aPostfixLength) {
> +

nit: Remove this line.
Attachment #8639290 - Flags: review?(shuang) → review+
Changes since v1:

  - updated coding style according to review
Attachment #8639290 - Attachment is obsolete: true
Attachment #8641564 - Flags: review+
Changes since v2:

  - rebased onto m-c
Attachment #8639299 - Attachment is obsolete: true
Attachment #8641565 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/bf83fb8e2edf
https://hg.mozilla.org/mozilla-central/rev/911af3f44bbc
https://hg.mozilla.org/mozilla-central/rev/30d6aae8ad3a
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S4 (07Aug)
You need to log in before you can comment on or make changes to this bug.