Closed Bug 1187905 Opened 6 years ago Closed 5 years ago

DevEdition light theme should use normal caption buttons

Categories

(Firefox :: Theme, defect, P2)

defect

Tracking

()

VERIFIED FIXED
Firefox 44
Tracking Status
firefox43 --- fixed
firefox44 --- verified

People

(Reporter: ntim, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

It currently uses the lightweight theme caption buttons.
Blocks: theme-win10
Duplicate of this bug: 1189259
Priority: -- → P1
Priority: P1 → P2
Uploading screenshot from Bug 1189259
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Bug 1187905 - use normal titlebar buttons for devtools light theme, r?bgrins
Attachment #8665907 - Flags: review?(bgrinstead)
Attachment #8665907 - Flags: review?(bgrinstead) → review+
Comment on attachment 8665907 [details]
MozReview Request: Bug 1187905 - use normal titlebar buttons for devtools light theme, r?bgrins

https://reviewboard.mozilla.org/r/20393/#review18329

LGTM
https://hg.mozilla.org/mozilla-central/rev/6afa97fa45e9
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Comment on attachment 8665907 [details]
MozReview Request: Bug 1187905 - use normal titlebar buttons for devtools light theme, r?bgrins

Approval Request Comment
[Feature/regressing bug #]: win10 support for devedition
[User impact if declined]: devedition light looks a little off on win10
[Describe test coverage new/current, TreeHerder]: nope!
[Risks and why]: very low risk, just a CSS change
[String/UUID change made/needed]: nope
Attachment #8665907 - Flags: approval-mozilla-aurora?
Comment on attachment 8665907 [details]
MozReview Request: Bug 1187905 - use normal titlebar buttons for devtools light theme, r?bgrins

Small css fix for Win10; let's uplift to aurora.
Attachment #8665907 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
I couldn't reproduce this bug on Windows 8.1 (64-bit) with firefox aurora 41.0a2 
(Build ID:20150727004009) but I have reproduced this bug on Windows 10 (64-bit) with firefox aurora 41.0a2 (Build ID:20150727004009).

Verified as fixed with firefox aurora 44.0a2 (Build ID: 20151118004041)

Mozilla/5.0 (Windows NT 10.0; WOW64; rv:44.0) Gecko/20100101 Firefox/44.0
QA Whiteboard: [bugday-20151125]
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.