1187956 - View source from SeaMonkey uses deprecated API

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Ian Neal]

Error: DEPRECATION WARNING: The arguments you're passing to viewSource.xul are using an out-of-date API.
You may find more details about this deprecation at: https://developer.mozilla.org/en-US/Add-ons/Code_snippets/View_Source_for_XUL_Applications
chrome://global/content/viewSource.js 316 _loadViewSourceDeprecated
chrome://global/content/viewSource.js 302 onXULLoaded
chrome://global/content/viewSource.js 175 handleEvent
null 0 null

Comment 1

[Ian Neal]

Attachment: Port changes to SeaMonkey

This ports the changes from:
* Bug 1025146 - Modernize viewSource.js to use a frame script
** https://hg.mozilla.org/mozilla-central/rev/13bf99d217bf
* Bug 1025146 - Make viewing the source of a page or frame via the context menu work with remote browsers
** http://hg.mozilla.org/mozilla-central/rev/28c41c53d0c2

Comment 2

[[e-mail]]

Comment on attachment 8639338 [details] [diff] [review]
Port changes to SeaMonkey

>+/**
>+ * Opens the View Source dialog for the source loaded in the root
>+ * top-level document of the browser. This is really just a
>+ * convenience wrapper around BrowserViewSourceOfDocument.
>+ *
>+ * @param aBrowser
>+ *        The browser that we want to load the source of.
>+ */
>+function BrowserViewSource(aBrowser) {
>+  BrowserViewSourceOfDocument({
>+    browser: aBrowser,
>+    outerWindowID: aBrowser.outerWindowID,
>+    URL: aBrowser.currentURI.spec,
>+  });
Why not call viewSourceUtils directly?

>   // Open new "view source" window with the frame's URL.
>   viewFrameSource: function() {
>-    BrowserViewSourceOfDocument(this.target.ownerDocument);
>+    BrowserViewSourceOfDocument({
>+      browser: this.browser,
>+      URL: gContextMenuContentData.docLocation,
>+      outerWindowID: gContextMenuContentData.frameOuterWindowID,
Our context menu content data doesn't include the outer window id yet.

>             window.openDialog( "chrome://global/content/viewSource.xul",
>-                               "_blank", "all,dialog=no", url,
>+                               "_blank", "all,dialog=no", {URL: url},
>                                mailCharacterSet);
This type of parameter ignores the character set, and because you don't provide a browser and outer window ID, it can't even try to grab the character set from the browser. (Always assuming that it's capable of grabbing the character set from the message pane...)

Comment 3

[Ian Neal]

Attachment: Port changes to SeaMonkey v1.1

Changes from previous patch:
* BrowserViewSource now uses viewSourceUtils directly.
* Added frameOuterWindowID to context menu content data.
* Use getBrowser() to pass browser and outerWindowID to viewSource.xul

Comment 4

[[e-mail]]

Comment on attachment 8639603 [details] [diff] [review]
Port changes to SeaMonkey v1.1

>+function BrowserViewSourceOfDocument(aArgsOrDocument) {
[Ugh, why did Firefox have to have this weird dance?]

>+  let args;
>+
>+  if (aArgsOrDocument instanceof Document) {
>+    let doc = aArgsOrDocument;
...
>+  } else {
>+    args = aArgsOrDocument;
>+  }
I don't think you need three variables for the same thing. Just use aArgsOrDocument.

>+      this.frameOuterWindowID = win.QueryInterface(Components.interfaces.nsIInterfaceRequestor)
>+                                   .getInterface(Components.interfaces.nsIDOMWindowUtils)
>+                                   .outerWindowID;
Don't need to set this; viewFrameSource only uses the other definition.

>+    BrowserViewSourceOfDocument({
Should be gViewSourceUtils again. (Sorry didn't notice you'd done it twice.)

r=me with the above fixed.

Comment 5

[Ian Neal]

(In reply to [e-mail] from comment #4)
> Comment on attachment 8639603 [details] [diff] [review]
> Port changes to SeaMonkey v1.1
> 
> >+    BrowserViewSourceOfDocument({
> Should be gViewSourceUtils again. (Sorry didn't notice you'd done it twice.)
Only thought about this and the previous one, is that when/if the open view source in a browser tab is ported, would need to switch back to calling BrowserViewSourceOfDocument. I am tempted to have them both calling BrowserViewSourceOfDocument again, what do you think?

Comment 6

[[e-mail]]

I'd create a new method (sorry can't think of a good name for it right now) which would handle the view source in a tab case. It would then just be a case of fixing up the three call sites.

Comment 7

[Philip Chee]

Bug 1067325 - Add an option to view html source in a tab

Comment 8

[Ian Neal]

Attachment: Port changes to SeaMonkey v1.2 [Checked in: Comment 10]

Comment 9

[Philip Chee]

Comment on attachment 8641045 [details] [diff] [review]
Port changes to SeaMonkey v1.2 [Checked in: Comment 10]

a=me for CLOSED TREE comm-central

Comment 10

[Ian Neal]

Comment on attachment 8641045 [details] [diff] [review]
Port changes to SeaMonkey v1.2 [Checked in: Comment 10]

http://hg.mozilla.org/comm-central/rev/4d05dd6f2b9f