Closed Bug 1188047 Opened 9 years ago Closed 9 years ago

Add accept-language header handling to subscribe

Categories

(Websites :: Basket, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bniolet, Assigned: pmac)

References

Details

Attachments

(1 file)

We need to pass language information to Basket / ExactTarget during the subscription. 

For Firefox Accounts users who opt-in to email, it's possible that you will get their subscription request *before* you see their corresponding fxa-register call which is currently receiving language information. The fxa-register calls are processed by a background event queue.

If the subscription request arrives before the language, we wouldn't have the necessary information to send a welcome email. 

See Bug 1179873 

https://bugzilla.mozilla.org/show_bug.cgi?id=1179873
Blocks: 1179873
Summary: Add language handling to subscribe → Add accept-language header handling to subscribe
Assignee: nobody → pmac
Commits pushed to master at https://github.com/mozilla/basket

https://github.com/mozilla/basket/commit/b90c22208d528e803150c44170a64df1b0137020
Fix bug 1188047: Add accept_lang support to subscribe.

Also updates get_best_language to also search for 2 letter
languages in our supported list.

https://github.com/mozilla/basket/commit/2634d4c983f10a87cf49ec48b0c46c9c37cc2d62
Merge pull request #143 from pmclanahan/add-accept-lang-subscribe-1188047

Fix bug 1188047: Add accept_lang support to subscribe.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
:pmac, please let me know when this is in production and I'll push though the corresponding fxa-content-serve changes.  Or tell me if there's a better system for knowing when this hits production than ":pmac tells me when it's in production" :-)
Flags: needinfo?(pmac)
Unfortunately, until we get basket moved to AWS I have to file bugs with webops to get basket deployed. But that means that I can CC you on the push bug and we'll know at the same time. Unless you tell me not to that's what I'll do.
Flags: needinfo?(pmac)
> I can CC you on the push bug

SGTM, thanks!
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: