Closebuttons are looking weird on hover

RESOLVED FIXED in 4.4

Status

Calendar
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

Trunk
All
Windows 8

Details

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
Created attachment 8639448 [details]
closebuttons.png

Bug 1173729 introduced a new closebutton image which is 20px * 20px for Win8 and Win10. This makes the buttons looking weird on Calendar when hovering (see screenshot).
(Assignee)

Comment 1

2 years ago
Created attachment 8639458 [details] [diff] [review]
closebutton.patch

Where are two possibilities to fix this. 1. use the close-XPVista7.png icon to look like before. And 2. fix the -moz-image-region.

I've chosen option 2 to be consistent with the FX sidebar closers.

Philipp, are you okay with this or do you want option 1?

Maybe we could also use the .close-icon class, then the icons are chosen by global.css and it would be HiDPI enabled. But this could also be done in a new bug because this affects then also OS X and Linux.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8639458 - Flags: review?(philipp)
Comment on attachment 8639458 [details] [diff] [review]
closebutton.patch

Review of attachment 8639458 [details] [diff] [review]:
-----------------------------------------------------------------

Fine with me, r=philipp
Attachment #8639458 - Flags: review?(philipp) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 3

2 years ago
https://hg.mozilla.org/comm-central/rev/e2e12c62ea7e
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 4.4
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.