Last Comment Bug 1188070 - Closebuttons are looking weird on hover
: Closebuttons are looking weird on hover
Status: RESOLVED FIXED
:
Product: Calendar
Classification: Client Software
Component: General (show other bugs)
: Trunk
: All Windows 8
-- normal (vote)
: 4.4
Assigned To: Richard Marti (:Paenglab)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2015-07-27 12:28 PDT by Richard Marti (:Paenglab)
Modified: 2015-08-07 03:20 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
closebuttons.png (5.79 KB, image/png)
2015-07-27 12:28 PDT, Richard Marti (:Paenglab)
no flags Details
closebutton.patch (1.81 KB, patch)
2015-07-27 12:36 PDT, Richard Marti (:Paenglab)
philipp: review+
Details | Diff | Splinter Review

Description User image Richard Marti (:Paenglab) 2015-07-27 12:28:14 PDT
Created attachment 8639448 [details]
closebuttons.png

Bug 1173729 introduced a new closebutton image which is 20px * 20px for Win8 and Win10. This makes the buttons looking weird on Calendar when hovering (see screenshot).
Comment 1 User image Richard Marti (:Paenglab) 2015-07-27 12:36:02 PDT
Created attachment 8639458 [details] [diff] [review]
closebutton.patch

Where are two possibilities to fix this. 1. use the close-XPVista7.png icon to look like before. And 2. fix the -moz-image-region.

I've chosen option 2 to be consistent with the FX sidebar closers.

Philipp, are you okay with this or do you want option 1?

Maybe we could also use the .close-icon class, then the icons are chosen by global.css and it would be HiDPI enabled. But this could also be done in a new bug because this affects then also OS X and Linux.
Comment 2 User image Philipp Kewisch [:Fallen] 2015-07-28 01:00:58 PDT
Comment on attachment 8639458 [details] [diff] [review]
closebutton.patch

Review of attachment 8639458 [details] [diff] [review]:
-----------------------------------------------------------------

Fine with me, r=philipp

Note You need to log in before you can comment on or make changes to this bug.