1188079 - Optimize return types for JSOP_POW

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect, P5)

Description

[Eric Faust [:efaust]]

In bug 1135708, we added support for the exponentiation operator. At present, we don't attach BC stubs, or try to optimize the return type of the generated ion Instructions to MIRType_Int32.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1188079 - Part 1: Add `pow32` to the MacroAssembler to allow reusing it for CacheIR. r=jandem!

Two branch conditions were inverted to generate fewer jump instructions in the loop body.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1188079 - Part 2: Add JSOP_POW support to CacheIR. r=jandem!

There were too few registers available on x86, so the code tries to reuse the output
operand's type register in addition to its payload register.

Depends on D39046

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1188079: Add Int32 specialisation for JSOp::Pow to Ion. r=jandem!

Depends on D39047

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1188079 - Part 4: Add Ion IC support for JSOP_POW. r=jandem!

Depends on D39048

Comment 5

[Phabricator Automation]

Comment on attachment 9080070 [details]
Bug 1188079 - Part 1: Add pow32 to the MacroAssembler to allow reusing it for CacheIR. r=jandem!

Revision D39046 was moved to bug 1620997. Setting attachment 9080070 [details] to obsolete.

Comment 6

[Phabricator Automation]

Comment on attachment 9080071 [details]
Bug 1188079 - Part 2: Add JSOP_POW support to CacheIR. r=jandem!

Revision D39047 was moved to bug 1620997. Setting attachment 9080071 [details] to obsolete.

Comment 7

[Phabricator Automation]

Comment on attachment 9080073 [details]
Bug 1188079 - Part 4: Add Ion IC support for JSOP_POW. r=jandem!

Revision D39049 was moved to bug 1620997. Setting attachment 9080073 [details] to obsolete.

Comment 8

[André Bargull [:anba]]

This was fixed across multiple bugs.