Closed Bug 1188095 Opened 6 years ago Closed 6 years ago

Muting audio in Graphene also pauses the video

Categories

(Firefox OS Graveyard :: Runtime, defect)

Product:
Firefox OS Graveyard
Component:
Runtime
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox42 fixed)

Status:
RESOLVED FIXED
Milestone:
FxOS-S4 (07Aug)
Tracking Flags:
Tracking Status
firefox42 --- fixed

People

(Reporter: bbondy, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

Don't pause media elements on 'graphene'
2.68 KB, patch
baku
: review+
Details | Diff | Splinter Review 
Muting / unmuting an audio channel is currently also pausing the video.

This can be reproduced in Graphene both at the individual audio channel level and using dom window utils audioMuted.

Note that Unmuting then resumes the paused video.

Note to Ehsan who said he'd take this:
You can detect if it's Graphene with: #ifdef MOZ_GRAPHENE

This may also happen in B2G, I haven't tried without Graphene.
MOZ_GRAPHENE is only on larch right now, sorry about that.
Note that MOZ_GRAPHENE currently only exists on the larch project branch,
but this is so simple that it seems worth taking.
Attachment #8639513 - Flags: review?(amarchesini)
Blocks: graphene
Summary: Muting audo in Graphene also pauses the video → Muting audio in Graphene also pauses the video
Attachment #8639513 - Flags: review?(amarchesini) → review+
https://hg.mozilla.org/mozilla-central/rev/c2f191de1c65
Assignee: nobody → ehsan
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S4 (07Aug)
You need to log in before you can comment on or make changes to this bug.