The default bug view has changed. See this FAQ.

Failed to read 'hs' and 'ds' errors in add to calendar button's drop down list

RESOLVED FIXED in 4.0.2

Status

Calendar
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: MakeMyDay, Assigned: merike)

Tracking

Lightning 4.0.1.2
4.0.2

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Localization for the list of "add as event/task" toolbar buttons seems to be incomplete. ds and hs cannot be resolved. For some emails, ds isn't offered in the list at all.

Zeitstempel: 27.07.2015 22:55:59
Fehler: Failed to read 'hs' from chrome://global/locale/languageNames.properties. Error: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource://calendar/modules/calUtils.jsm -> file:///C:/Users/.../AppData/Roaming/Thunderbird/Profiles/7yrfxmv9.default/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/calendar-js/calUtils.js :: calGetString :: line 676"  data: no]

Zeitstempel: 27.07.2015 22:55:59
Fehler: Failed to read 'ds' from chrome://global/locale/languageNames.properties. Error: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource://calendar/modules/calUtils.jsm -> file:///C:/Users/.../AppData/Roaming/Thunderbird/Profiles/7yrfxmv9.default/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/calendar-js/calUtils.js :: calGetString :: line 676"  data: no]

Comment 1

2 years ago
There are no existing 'hs' or 'ds' localizations. 
But 'hsb' (Upper Sorbian) and 'dsb' (Lower Sorbian) exists.
Looks like something with the extractor. Merike, can you advise?
Flags: needinfo?(merikes.lists)
(Assignee)

Comment 3

2 years ago
Created attachment 8639839 [details] [diff] [review]
bug1188111

It seems Sorbian is the first three character locale included into Lightning.

This should fix it, I have not tested it though. How would I build Lightning with all locales locally?
Assignee: nobody → merikes.lists
Status: NEW → ASSIGNED
Flags: needinfo?(merikes.lists)
Attachment #8639839 - Flags: review?(philipp)
Comment on attachment 8639839 [details] [diff] [review]
bug1188111

Review of attachment 8639839 [details] [diff] [review]:
-----------------------------------------------------------------

I think the easiest way to test would be to just copy in the calendar-dsb/lightning-dsb chrome directories (or jars) and then editing chrome.manifest to include them. Codewise this looks fine, but obviously some testing would be nice.
Attachment #8639839 - Flags: review?(philipp) → review+
(Reporter)

Comment 5

2 years ago
We should consider this for 4.0.2, too.
Blocks: 1180416
(Assignee)

Comment 6

2 years ago
I ended up modifying the file in a profile using 4.0.1.2 from AMO. Worked as expected for me after that: no more errors for Sorbian and extraction itself still worked for en-US. Even Upper Sorbian seemed to pick up data from email.
Keywords: checkin-needed
url:        https://hg.mozilla.org/releases/comm-esr38/rev/2b7c498c0b74e6cc8fd32675605c16b1632667cd
changeset:  2b7c498c0b74e6cc8fd32675605c16b1632667cd
user:       Merike Sell <merike.sell@eesti.ee>
date:       Tue Aug 04 23:54:59 2015 +0200
description:
Bug 1188111 - Failed to read 'hs' and 'ds' errors in add to calendar button's drop down list. r=philipp,a=rkent
pushed to comm-esr38 since we needed to push something for testing the m-esr38 merge. This still needs to be pushed on aurora/beta/central.
Target Milestone: --- → 4.0.2
Attachment #8639839 - Flags: approval-calendar-release+
Attachment #8639839 - Flags: approval-calendar-beta+
Attachment #8639839 - Flags: approval-calendar-aurora+
(Reporter)

Comment 9

2 years ago
https://hg.mozilla.org/comm-central/rev/b152d30ce818
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Whiteboard: [aurora][beta]
url:        https://hg.mozilla.org/releases/comm-aurora/rev/8e324eaa1acce37164b4d56e58c2367c19900adb
changeset:  8e324eaa1acce37164b4d56e58c2367c19900adb
user:       Merike Sell <merike.sell@eesti.ee>
date:       Sat Aug 08 11:26:05 2015 +0100
description:
Bug 1188111 - Failed to read 'hs' and 'ds' errors in add to calendar button's drop down list. r/a=philipp
url:        https://hg.mozilla.org/releases/comm-beta/rev/527220c6962b925dc54ad747835095f338ff6ded
changeset:  527220c6962b925dc54ad747835095f338ff6ded
user:       Merike Sell <merike.sell@eesti.ee>
date:       Sat Aug 08 11:26:05 2015 +0100
description:
Bug 1188111 - Failed to read 'hs' and 'ds' errors in add to calendar button's drop down list. r/a=philipp
Keywords: checkin-needed
Whiteboard: [aurora][beta]
You need to log in before you can comment on or make changes to this bug.