1188165 - [NFC] Homescreen icons are visible behind the shrinking UI.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Martin Shuman [:Marty]]

Attachment: logcat-nfc.txt

Description:
When using NFC, the shrinking UI will show the homescreen icons behind the shrunken app view.  It does not show the wallpaper, appearing as if homescreen is in edit mode. These apps are not selectable, but can obscure the 'swipe to share' text and arrow.

This occurs when sharing from Gallery, Browser, and Videos

Repro Steps:
1) Update a Aries to 20150727151800
2) Enable NFC on the DUT and another device.
3) Navigate to the Gallery and view a picture fullscreen
4) Tap the back of the two devices together to trigger the shrinking UI.


Actual:
Shrinking UI shows homescreen icons behind current app.

Expected:
Shrinking UI does not show homescreen icons.

Environmental Variables:
Device: Aries 2.5
Build ID: 20150727151800
Gaia: 4e3e21a4ba3f188b45623ee2297f21d0791f8667
Gecko: 21ca97268bae
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 42.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Repro frequency: 10/10
See attached: Screenshot, Logcat

Comment 1

[Martin Shuman [:Marty]]

Attachment: NFC-Screenshot.png

Comment 2

[Martin Shuman [:Marty]]

This issue DOES occur on Flame 2.5 builds.
Shrinking UI shows homescreen icons behind current app.

Environmental Variables:
Device: Flame 2.5
Build ID: 20150727074921
Gaia: 4e3e21a4ba3f188b45623ee2297f21d0791f8667
Gecko: 21ca97268bae
Gonk: 41d3e221039d1c4486fc13ff26793a7a39226423
Version: 42.0a1 (2.5)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

-----------------------

This issue does NOT occur on Flame 2.2 builds.
Shrinking UI does not show homescreen icons.

Environmental Variables:
Device: Flame 2.2
Build ID: 20150727032503
Gaia: e1e6317f17a840b19af9dbb25f5a771d8d9fa161
Gecko: 551aee22a380
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 3

[Peter Bylenga [:PBylenga]]

NI on component owner for nomination decision and assignment.

Comment 4

[No-Jun Park [:njpark]]

[Blocking Requested - why for this release]:

I think it's a blocker since it's clearly showing something that it shouldn't.

Comment 6

[Pi Wei Cheng [:piwei] (inactive)]

Adding window-wanted since 1192110 asked for that. I'll be working on getting the window.

Comment 7

[Pi Wei Cheng [:piwei] (inactive)]

central regression window:

Last Working
Device: Flame
BuildID: 20150713194048
Gaia: 7676b68b4d32ed13243eeb719188847121bd5611
Gecko: 0931671a14ef
Version: 42.0a1 (2.5 Master) 
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

First Broken
Device: Flame
BuildID: 20150714025548
Gaia: 66638d0e65bf58b7f640bcc7bed4a0b23d1356c6
Gecko: 5bd5ca3ad614
Version: 42.0a1 (2.5 Master) 
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Last Working Gaia First Broken Gecko - no repro
Gaia: 7676b68b4d32ed13243eeb719188847121bd5611
Gecko: 5bd5ca3ad614

Last Working Gecko First Broken Gaia - repro
Gaia: 66638d0e65bf58b7f640bcc7bed4a0b23d1356c6
Gecko: 0931671a14ef

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/7676b68b4d32ed13243eeb719188847121bd5611...66638d0e65bf58b7f640bcc7bed4a0b23d1356c6

Caused by changes made in Bug 1179040.

Comment 8

[KTucker [:KTucker][Inactive 3/4/2016]]

Etienne, can you take a look at this please? This might have been caused by the landing for bug 1179040.

Comment 9

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

identifiable regression

Comment 10

[Ken Chang[:kenkai]]

According to Comment 8, this bug should not a NFC bug.

Comment 11

[GitHub Autolander Bot]

Attachment: [gaia] etiennesegonzac:bug-1188165 > mozilla-b2g:master

Comment 12

[Etienne Segonzac (:etienne)]

Comment on attachment 8647544 [details] [review]
[gaia] etiennesegonzac:bug-1188165 > mozilla-b2g:master

Hey John,
I'd like to start exchanging more reviews with you, but feel free to redirect this to Alberto if you don't have the bandwidth.

About the patch:
we use to remove the "fade overlay" of the homescreen during NFC sharing to display the system background.
This doesn't work anymore because, like you can see in the bug's screenshot
- the system background isn't showing anyway
- gecko tries to keep the layer tree alive when we setVisible(false) an iframe now, so the homescreen icons are showing up

This patch removes this broken behavior so that we get a clean black background (the homescreen fade overlay) during NFC sharing.

Comment 13

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8647544 [details] [review]
[gaia] etiennesegonzac:bug-1188165 > mozilla-b2g:master

Looks good to me. Thanks.

BTW, I found another issue of bug 1179040. I will put message at bug 1179040.

Comment 14

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/28033c517217fef554c0051fbee05b5fa44db68e

Comment 15

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: Shrinking UI does not show homescreen icons.
See attachment: verified_FlameKK_v2.5.3gp
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20150816150205
Gaia Revision          47c91ffe7f500ca1aaa60de0aabf4d2429120733
Gaia Date              2015-08-14 18:55:02
Gecko Revision         https://hg.mozilla.org/mozilla-
central/rev/0876695d1abdeb363a780bda8b6cc84f20ba51c9
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150816.182145
Firmware Date          Sun Aug 16 18:21:56 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5(Pass)
Build ID               20150816151853
Gaia Revision          47c91ffe7f500ca1aaa60de0aabf4d2429120733
Gaia Date              2015-08-14 18:55:02
Gecko Revision         https://hg.mozilla.org/mozilla-
central/rev/0876695d1abdeb363a780bda8b6cc84f20ba51c9
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150816.144248
Firmware Date          Sun Aug 16 14:42:55 UTC 2015
Bootloader             s1

Comment 16

[Shally Li（leave from Mozilla）]

Attachment: verified_Flame_v2.5.3gp