Closed Bug 1188186 Opened 4 years ago Closed 4 years ago

Possible leak of FDs in |CreateTransport|

Categories

(Core :: IPC, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: erahm, Assigned: paul.bignier)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: [CID 1293112][CID 1293113])

Attachments

(1 file, 1 obsolete file)

Coverity indicates it's possible to leak |fd1| or |fd2| on early return [1] in the posix version for |CreateTransport| [2].

[1] https://hg.mozilla.org/mozilla-central/annotate/2ddec2dedced/ipc/glue/Transport_posix.cpp#l43
[2] https://hg.mozilla.org/mozilla-central/annotate/2ddec2dedced/ipc/glue/Transport_posix.cpp#l25
Attached patch Free fd1 & fd2 (obsolete) — Splinter Review
Mimicking ipc_channel_posix.cc's closing behavior.
Attachment #8694257 - Flags: review?(benjamin)
Attachment #8694257 - Flags: review?(benjamin) → review+
Attached patch Free fd1 & fd2Splinter Review
Just rebased, fixed the username & commit message :)
Attachment #8694257 - Attachment is obsolete: true
Attachment #8695770 - Flags: review?(benjamin)
Comment on attachment 8695770 [details] [diff] [review]
Free fd1 & fd2

Don't need to re-review ;-)

Do you need help getting this landed?
Flags: needinfo?(paul.bignier)
Attachment #8695770 - Flags: review?(benjamin) → review+
Assignee: nobody → paul.bignier
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #3)
> Comment on attachment 8695770 [details] [diff] [review]
> Free fd1 & fd2
> 
> Don't need to re-review ;-)
> 
> Do you need help getting this landed?

Guess I should follow the steps: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Landing_a_patch so start using Mercurial instead of Git. Will do asap.
Thank you,
Paul
Flags: needinfo?(paul.bignier)
Actually don't have commit access, so just adding the keyword :)
Keywords: checkin-needed
Yep! We're all at a workweek this week so response may be slow, but sheriffs will help get this landed. Did you do a try run?
Flags: needinfo?(paul.bignier)
https://hg.mozilla.org/mozilla-central/rev/b0da06541b82
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Flags: needinfo?(paul.bignier)
You need to log in before you can comment on or make changes to this bug.