1188186 - Possible leak of FDs in |CreateTransport|

Status: RESOLVED FIXED

(Core :: IPC, enhancement)

Description

[Eric Rahm [:erahm]]

Coverity indicates it's possible to leak |fd1| or |fd2| on early return [1] in the posix version for |CreateTransport| [2].

[1] https://hg.mozilla.org/mozilla-central/annotate/2ddec2dedced/ipc/glue/Transport_posix.cpp#l43
[2] https://hg.mozilla.org/mozilla-central/annotate/2ddec2dedced/ipc/glue/Transport_posix.cpp#l25

Comment 1

[Paul Bignier]

Attachment: Free fd1 & fd2

Mimicking ipc_channel_posix.cc's closing behavior.

Comment 2

[Paul Bignier]

Attachment: Free fd1 & fd2

Just rebased, fixed the username & commit message :)

Comment 3

[Benjamin Smedberg]

Comment on attachment 8695770 [details] [diff] [review]
Free fd1 & fd2

Don't need to re-review ;-)

Do you need help getting this landed?

Comment 4

[Paul Bignier]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #3)
> Comment on attachment 8695770 [details] [diff] [review]
> Free fd1 & fd2
> 
> Don't need to re-review ;-)
> 
> Do you need help getting this landed?

Guess I should follow the steps: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Landing_a_patch so start using Mercurial instead of Git. Will do asap.
Thank you,
Paul

Comment 5

[Paul Bignier]

Actually don't have commit access, so just adding the keyword :)

Comment 6

[Benjamin Smedberg]

Yep! We're all at a workweek this week so response may be slow, but sheriffs will help get this landed. Did you do a try run?

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b0da06541b82

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b0da06541b82