Closed Bug 1188186 Opened 4 years ago Closed 4 years ago
Possible leak of FDs in |Create
Coverity indicates it's possible to leak |fd1| or |fd2| on early return  in the posix version for |CreateTransport| .  https://hg.mozilla.org/mozilla-central/annotate/2ddec2dedced/ipc/glue/Transport_posix.cpp#l43  https://hg.mozilla.org/mozilla-central/annotate/2ddec2dedced/ipc/glue/Transport_posix.cpp#l25
Mimicking ipc_channel_posix.cc's closing behavior.
Attachment #8694257 - Flags: review?(benjamin)
Just rebased, fixed the username & commit message :)
Comment on attachment 8695770 [details] [diff] [review] Free fd1 & fd2 Don't need to re-review ;-) Do you need help getting this landed?
Attachment #8695770 - Flags: review?(benjamin) → review+
(In reply to Benjamin Smedberg [:bsmedberg] from comment #3) > Comment on attachment 8695770 [details] [diff] [review] > Free fd1 & fd2 > > Don't need to re-review ;-) > > Do you need help getting this landed? Guess I should follow the steps: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Landing_a_patch so start using Mercurial instead of Git. Will do asap. Thank you, Paul
Actually don't have commit access, so just adding the keyword :)
Yep! We're all at a workweek this week so response may be slow, but sheriffs will help get this landed. Did you do a try run?
You need to log in before you can comment on or make changes to this bug.