Closed Bug 1188223 Opened 8 years ago Closed 7 years ago
Reader font type overflow in Japanese
User Agent: Mozilla/5.0 (Windows NT 6.3; rv:39.0) Gecko/20100101 Firefox/39.0 Build ID: 20150630154324 Steps to reproduce: 1) Run Firefox (ja-JP) 2) Navigate "Getting Started" (https://support.mozilla.org/ja/kb/get-started-firefox-overview-main-features) 3) View reader mode 4) Click style-button in reader-toolbar Actual results: Japanese font overflow. Expected results: Should be fit into the area of style-button.
Component: Untriaged → Reading List
OS: Unspecified → Windows 8.1
Hardware: Unspecified → x86
Product: Firefox → Firefox Graveyard
Component: Reading List → Reader Mode
Product: Firefox Graveyard → Toolkit
Blake, this seems to be a regression from bug 1148050? Can you perhaps look at this? Where are the 2 misplaced characters coming from? There are normally-sized (english Aa/+/-) controls there too, so seems like this just should be shown at all. Is it enough to just run a ja-JP-mac localized build to reproduce?
Too late for beta 46, but we could still take a patch for 47. Not a recent regression but sounds like we missed this from last year and it is bad for users.
And I'm not seeing this in 48.0a1 (2016-04-04) or 46.0b5 (although it is there in 45… 48: https://www.dropbox.com/s/6khc6e70ib88agh/Screenshot%202016-04-04%2019.12.18.png?dl=0 46: https://www.dropbox.com/s/pp9l6c3la8qyuo0/Screenshot%202016-04-04%2019.17.16.png?dl=0 45: https://www.dropbox.com/s/ozycq2comwlrq46/Screenshot%202016-04-04%2019.26.01.png?dl=0 The ja locale file seems to only have Aa, as per https://github.com/mozilla-japan/gecko-l10n/blob/9f461e6188f8ed4103e664473b0d2c997c8f2bb1/ja/toolkit/chrome/global/aboutReader.properties#L22 Hang on a second… Oh, it looks like it was a bug in that file which was fixed on Feb 26th-ish… https://github.com/mozilla-japan/gecko-l10n/commit/9d40774a7f14d09a15d476de872fefbe3795ea0e#diff-5174a8811c6e48821bcaed103f78e3fcL18 so, uh, problem solved?
Yeah, that sounds like this was fixed by a L10N change.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Updating status 47 and 48 to fixed based on comment 4.
Hello magicp, could you please verify this issue is fixed on a latest Nightly build? Thanks!
I confirmed this bug by STR, but reader-mode-button does not appear in Japanese. Please find attached image.
(In reply to magicp from comment #7) > Created attachment 8748380 [details] > Bug 1188223 - cannot verify in Japanese.png > > I confirmed this bug by STR, but reader-mode-button does not appear in > Japanese. Please find attached image. That's not good. Could you please file a new bug on this issue?
I confirmed that this issue is fixed on Nightly build (20160504043118). But confirmed page is below. https://developer.mozilla.org/ja/Add-ons/WebExtensions/Your_first_WebExtension
(In reply to Ritu Kothari (:ritu) from comment #8) > That's not good. Could you please file a new bug on this issue? Yes I can. What component is this new bug? reader mode or website?
(In reply to magicp from comment #10) > (In reply to Ritu Kothari (:ritu) from comment #8) > > > That's not good. Could you please file a new bug on this issue? > > Yes I can. What component is this new bug? reader mode or website? Please file a readability github issue: https://github.com/mozilla/readability/issues
(In reply to :Gijs Kruitbosch from comment #11) > (In reply to magicp from comment #10) > Please file a readability github issue: https://github.com/mozilla/readability/issues https://github.com/mozilla/readability/issues/290
You need to log in before you can comment on or make changes to this bug.