Closed Bug 1188274 Opened 5 years ago Closed 4 years ago

Intermittent apps/ftu/test/marionette/language_pseudo_localization_test.js | First Time Use > Pseudo Localization FTU Languages without pseudo localization

Categories

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.6 S5 - 1/15

People

(Reporter: gerard-majax, Assigned: sfoster)

References

Details

(Keywords: intermittent-failure, Whiteboard: [systemsfe][MJS])

Attachments

(1 file)

Blocks: 1188276
No longer blocks: 1188276
Summary: apps/ftu/test/marionette/language_pseudo_localization_test.js | First Time Use > Pseudo Localization FTU Languages without pseudo localization → Intermittent apps/ftu/test/marionette/language_pseudo_localization_test.js | First Time Use > Pseudo Localization FTU Languages without pseudo localization
Whiteboard: systemsfe
Summary: Intermittent apps/ftu/test/marionette/language_pseudo_localization_test.js | First Time Use > Pseudo Localization FTU Languages without pseudo localization → Intermittent apps/ftu/test/marionette/language_pseudo_localization_test.js | First Time Use > Pseudo Localization FTU Languages with/without pseudo localization
Duplicate of this bug: 1188276
Most likely this will be fixed by the patch in bug 1181419.
Assignee: nobody → kevingrandon
Going to hope that this is resolved now with bug 1181419 landing.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
(In reply to Kevin Grandon :kgrandon from comment #17)
> Going to hope that this is resolved now with bug 1181419 landing.

I still see it ...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
[Mass Closure] Closing Intermittent as a one off
Status: REOPENED → RESOLVED
Closed: 5 years ago4 years ago
Resolution: --- → WORKSFORME
Still seeing this, especially when I disable the retry logic in bug 1222215. For instance [1]. I'm going to disable this test.

1.) https://treeherder.mozilla.org/logviewer.html#?job_id=3235176&repo=gaia
Assignee: kevin+bugzilla → nobody
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Summary: Intermittent apps/ftu/test/marionette/language_pseudo_localization_test.js | First Time Use > Pseudo Localization FTU Languages with/without pseudo localization → Intermittent apps/ftu/test/marionette/language_pseudo_localization_test.js | First Time Use > Pseudo Localization FTU Languages without pseudo localization
Whiteboard: systemsfe → [systemsfe][MJS]
Assignee: nobody → sfoster
Target Milestone: --- → 2.6 S5 - 1/15
Comment on attachment 8704787 [details] [review]
[gaia] sfoster:ftu-l10n-gij-intermittent-bug-1188274 > mozilla-b2g:master

This latest version of the PR looks pretty stable. The main changes: 
* Reworking the language-list ready check to look for a data attribute and wait for at least one <li> to be visible. That in turn makes the waitForFtuReady method more stable. 
* A faster test for the lack of an element in this language list via a new findElement method on the Ftu test helper. Better spelled as findElementNow? meh, whatever :) 
* Guard against a race that has the sim lock popup being closed after its DOM has been destroyed (shows up when the test runs on device)
* Split the pseudo-locale tests into 2 files: one with the setting enabled, one without. This avoids a suspected race with updating settings while testing code in the startup path.
Attachment #8704787 - Flags: review?(mhenretty)
Comment on attachment 8704787 [details] [review]
[gaia] sfoster:ftu-l10n-gij-intermittent-bug-1188274 > mozilla-b2g:master

Great work here Sam, love seeing splitting out the tests like this and improving the library functions.
Attachment #8704787 - Flags: review?(mhenretty) → review+
Thanks, merged to master: 
https://github.com/mozilla-b2g/gaia/commit/bba41eaf21e644dec4782fd915bbe0e9b51d19f1
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.