1188281 - Revert part of Bug 1176205 once search suggestions hit Aurora

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Marco Bonardo [:mak]]

Once we signoff to enable the feature in Aurora, we need to revert part of Bug 1176205.

Comment 1

[:shell escalante]

want to pull in 42.3

Comment 2

[Marco Bonardo [:mak]]

As I said in the mail thread
"We should probably wrap the unifiedcomplete pref in firefox.js in an #ifdef NIGHTLY_BUILD (true/false) so we don't have to run after the merge day. we should also change the ifdefs hiding the prefs to instead check the unifiedcomplete pref. That will make much easier to switch on/off the feature (just by removing the ifdefs in firefox.js) and it's clear we are releasing the 2 things at the same time."

Instead of making these dependent on nightly build, we should make them dependent on unifiedcomplete pref, that should be easy to do with a simple change in privacy.js (both flavors)
If then we set unifiedcomplete pref to true for nightly and false otherwise, we are fine.

To enable the feature in Aurora we'll just have to touch firefox.js at that point.

I can either take this tomorrow, or someone else could, would be nice to land before the merge.

Comment 3

[Marco Bonardo [:mak]]

note: also browser_privacypane_5.js needs the same fix.

Comment 4

[Dave Townsend [:mossop]]

I'll work on this.

Comment 5

[Dave Townsend [:mossop]]

Attachment: patch

Spinning through try now but this look right. I've assumed we don't need to pref off search suggests when unified autocomplete is preffed off anyway so we have just one ifdef to remove.

Comment 6

[Drew Willcoxon :adw]

Looks right to me, and your assumption is correct.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/213cb104d7b1

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/213cb104d7b1

Comment 9

[Petruta Horea [:phorea], Desktop QA]

Setting browser.urlbar.suggest.searches to true in latest Developer Edition 42.0a2 (2015-08-13 20150813124640) doesn't show search suggestions in url bar.

browser.urlbar.userMadeSearchSuggestionsChoice;true also doesn't make any difference.

Will search suggestions be on only in 43 train?

Comment 10

[Marco Bonardo [:mak]]

(In reply to Petruta Rasa [QA] [:petruta] from comment #9)
> Setting browser.urlbar.suggest.searches to true in latest Developer Edition
> 42.0a2 (2015-08-13 20150813124640) doesn't show search suggestions in url
> bar.

That's expected, cause browser.urlbar.unifiedcomplete is false. suggestions only work when unifiedcomplete is being used.

> Will search suggestions be on only in 43 train?

No, they will be enabled in 42 when P1s blocking them are resolved.