Closed Bug 1188281 Opened 4 years ago Closed 4 years ago

Revert part of Bug 1176205 once search suggestions hit Aurora

Categories

(Firefox :: Address Bar, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 42
Iteration:
42.3 - Aug 10
Tracking Status
firefox42 --- fixed

People

(Reporter: mak, Assigned: mossop)

References

Details

(Whiteboard: [suggestions][fxsearch])

Attachments

(1 file)

Once we signoff to enable the feature in Aurora, we need to revert part of Bug 1176205.
Flags: firefox-backlog+
Summary: Revert part of Bug 1176205 once we ride the train → Revert part of Bug 1176205 once search suggestions hit Aurora
want to pull in 42.3
Iteration: --- → 42.3 - Aug 10
Rank: 5
Priority: P2 → P1
As I said in the mail thread
"We should probably wrap the unifiedcomplete pref in firefox.js in an #ifdef NIGHTLY_BUILD (true/false) so we don't have to run after the merge day. we should also change the ifdefs hiding the prefs to instead check the unifiedcomplete pref. That will make much easier to switch on/off the feature (just by removing the ifdefs in firefox.js) and it's clear we are releasing the 2 things at the same time."

Instead of making these dependent on nightly build, we should make them dependent on unifiedcomplete pref, that should be easy to do with a simple change in privacy.js (both flavors)
If then we set unifiedcomplete pref to true for nightly and false otherwise, we are fine.

To enable the feature in Aurora we'll just have to touch firefox.js at that point.

I can either take this tomorrow, or someone else could, would be nice to land before the merge.
note: also browser_privacypane_5.js needs the same fix.
I'll work on this.
Attached patch patchSplinter Review
Spinning through try now but this look right. I've assumed we don't need to pref off search suggests when unified autocomplete is preffed off anyway so we have just one ifdef to remove.
Attachment #8644006 - Flags: review?(mak77)
Looks right to me, and your assumption is correct.
Attachment #8644006 - Flags: review?(mak77) → review+
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/213cb104d7b1
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Setting browser.urlbar.suggest.searches to true in latest Developer Edition 42.0a2 (2015-08-13 20150813124640) doesn't show search suggestions in url bar.

browser.urlbar.userMadeSearchSuggestionsChoice;true also doesn't make any difference.

Will search suggestions be on only in 43 train?
(In reply to Petruta Rasa [QA] [:petruta] from comment #9)
> Setting browser.urlbar.suggest.searches to true in latest Developer Edition
> 42.0a2 (2015-08-13 20150813124640) doesn't show search suggestions in url
> bar.

That's expected, cause browser.urlbar.unifiedcomplete is false. suggestions only work when unifiedcomplete is being used.

> Will search suggestions be on only in 43 train?

No, they will be enabled in 42 when P1s blocking them are resolved.
You need to log in before you can comment on or make changes to this bug.