1188357 - Clean up and modernize iframed package code

Status: VERIFIED FIXED

(Marketplace Graveyard :: Code Quality, enhancement, P3)

Description

[Mathieu Pillard [:mat]]

The iframed package code was originally a quick hack, but it has grown and has stayed our official package for Firefox OS, as we have abandoned plans for a true packaged app.

But we never cleaned it up, and it shows. There is only one js file, main.js, which does everything, with no clean modules etc. This makes working on the iframed packaged a pain, especially since it also makes it super difficult to unit-test.

We should:
- Split the js files
- Start using requirejs or equivalent
- Move translations to our real l10n system
- Unit test everything

Some of those tasks should be done in smaller bugs that block this one.

Comment 1

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/fireplace/commit/4fcdde326e2b1327c5c43607ed9f802ecba80273

Keeping the bug opened to make a new dev package to QA it.

Comment 2

[Mathieu Pillard [:mat]]

QA:
- Install latest mkt-dev package and make sure it starts correctly and that:
  - Error messages for incorrect date and lack of network connectivity still works and are translated
  - Logging in using FxA etc still works
  - Web Activities still work
  - Feature profile information is properly transmitted. You can check that by going to :debug -> view feature profile information, and making sure it's the same info as the prod package (you can also check that the amount of RAM reported matches what your device has)


This will *not* go out next week, we'll need to release a new package for that. I've set the milestone for the week after next.

Comment 3

[Victor Carciu]

Verified as fixed based on steps from comment #2