1188387 - URI is not loaded in case some failure occurs in nsHttpChannel::ProcessNotModified

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Michal Novotny [:michal]]

I hit this problem while testing bug 1177278. If something goes wrong in nsHttpChannel::ProcessNotModified (e.g. CacheEntry::SetMetadataElement returns NS_ERROR_OUT_OF_MEMORY) then nsHttpChannel::ProcessNormal is called and continues like it wasn't a conditional request, so no content is served by the channel. We should handle this in the same way we recover from CacheFile error, i.e. do an internal redirect.

Comment 1

[Michal Novotny [:michal]]

Honza, you know this code better than me, do you want to take the bug?

Comment 2

[Honza Bambas (:mayhemer)]

Yep.  Thanks.

Comment 3

[Honza Bambas (:mayhemer)]

Attachment: v1

potential patch, I'll look over it more and then submit rr.

Comment 4

[Honza Bambas (:mayhemer)]

Attachment: v1.1

Slightly updated.
- problem was that ProcessNotModified could fail even when it just had to be bypassed
- hence I introduced ShouldBypassProcessNotModified() method that does the checks and can be used separately
- when process modified fails, we do the internal redirect via StartRedirectChannelToURI (it correctly handles redirect vetoing/proceeding)
- entry is doomed and threw away


https://treeherder.mozilla.org/#/jobs?repo=try&revision=252d6d76a3f4

Comment 5

[Honza Bambas (:mayhemer)]

Michal, ping on a review here. Thanks.

Comment 6

[Honza Bambas (:mayhemer)]

Rebase, retest, land...

Comment 7

[Honza Bambas (:mayhemer)]

Attachment: v1.1 [rebased]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=28b551603729

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d922a8d7ed26
On failure of nsHttpChannel::ProcessNotModified redirect to reload from network, r=michal

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d922a8d7ed26