New repositories on hgweb machines don't have proper permissions

RESOLVED FIXED

Status

Developer Services
Mercurial: hg.mozilla.org
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: gps, Assigned: gps)

Tracking

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Our permissions cron job on hgweb sent an update last night reflecting updates to a number of user repositories, namely repos under /repo/hg/mozilla/users/m_owca.info/. Looking at file times, it appears these repos were created yesterday. So, I can only infer that mirror-pull is failing to set the proper permissions on newly-created repositories.
(Assignee)

Comment 1

3 years ago
Created attachment 8683263 [details]
MozReview Request: ansible/hg-web: normalize repo permissions during creation (bug 1188433); r?fubar

ansible/hg-web: normalize repo permissions during creation (bug 1188433); r?fubar

If we don't do this, new repos don't have fully proper permissions.

We could probably do this by setting umask appropriately. However, let's
not take any chances and just use our normalization script: that's what
it's there for.

This change should stop the stem of daily CRON emails spamming us about
permissions changes after a new user repo is created.
Attachment #8683263 - Flags: review?(klibby)
(Assignee)

Updated

3 years ago
Assignee: nobody → gps
Status: NEW → ASSIGNED

Updated

3 years ago
Attachment #8683263 - Flags: review?(klibby) → review+
Comment on attachment 8683263 [details]
MozReview Request: ansible/hg-web: normalize repo permissions during creation (bug 1188433); r?fubar

https://reviewboard.mozilla.org/r/24247/#review21723

> We could probably do this by setting umask appropriately. However, let's
not take any chances and just use our normalization script: that's what
it's there for.

reuse code?!? crazy talk!  

shipit
(Assignee)

Comment 3

3 years ago
https://hg.mozilla.org/hgcustom/version-control-tools/rev/22455b8d0980d091aaaa7bc8b0172bf2b2a2b160
ansible/hg-web: normalize repo permissions during creation (bug 1188433); r=fubar
(Assignee)

Comment 4

3 years ago
Will deploy shortly.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.