Closed Bug 1188439 Opened 8 years ago Closed 8 years ago

Fix GMPLoader.cpp compilation with sandbox disabled.

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla42
Tracking Flags:
Tracking Status
firefox42 --- fixed

People

(Reporter: jacek, Assigned: jacek)

Details

Attachments

(1 file)

fix
2.79 KB, patch
cpearce
: review+
Details | Diff | Splinter Review
Attached patch fix — — Splinter Review 
widePath is used in Windows even if sandbox is disabled (like in mingw builds). The patch moves #ifdefs to handle that.
Attachment #8639910 - Flags: review?(cpearce)
Comment on attachment 8639910 [details] [diff] [review]
fix

Review of attachment 8639910 [details] [diff] [review]:
-----------------------------------------------------------------

I don't recommend disabling the sandbox.
Attachment #8639910 - Flags: review?(cpearce) → review+
https://hg.mozilla.org/mozilla-central/rev/48085d776a69
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox42: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.