1188442 - Fix IMMHandler.cpp compilation on mingw.

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Jacek Caban]

Attachment: fix

Errors look like this:

IMMHandler.cpp:1240:38: error: invalid initialization of non-const reference of type ‘mozilla::widget::IMMHandler::Selection&’ from an rvalue of type ‘mozilla::widget::IMMHandler::Selection’

Comment 1

[Masatoshi Kimura [:emk]]

Nakano-san, is it correct to copy-construct here?

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

So, not intentional. I'll create a patch for this.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: IMMHandler::GetSelection() should use static Selection instance when IME doesn't have focus and return its or mSelection's reference

This should fix the bustage and the unexpected behavior.

Comment 4

[Masatoshi Kimura [:emk]]

Comment on attachment 8642322 [details] [diff] [review]
IMMHandler::GetSelection() should use static Selection instance when IME doesn't have focus and return its or mSelection's reference

Review of attachment 8642322 [details] [diff] [review]:
-----------------------------------------------------------------

jacek, is this work with mingw?

::: widget/windows/IMMHandler.h
@@ +438,5 @@
>      bool EnsureValidSelection(nsWindow* aWindow);
> +  private:
> +    Selection(const Selection& aOther)
> +    {
> +      MOZ_CRASH("Don't copy this class");

Selection(const Selection& aOther) = delete;
Please also add
  void operator =(const Selection& aOther) = delete;

Comment 5

[Masatoshi Kimura [:emk]]

Comment on attachment 8639913 [details] [diff] [review]
fix

Superceded by Masayuki's patch.

Comment 6

[Jacek Caban]

Comment on attachment 8642322 [details] [diff] [review]
IMMHandler::GetSelection() should use static Selection instance when IME doesn't have focus and return its or mSelection's reference

Works for me, thanks.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/3f700e2cebbcc625c2f2aa6d6d857609e8afd8be
changeset:  3f700e2cebbcc625c2f2aa6d6d857609e8afd8be
user:       Masayuki Nakano <[e-mail]>
date:       Tue Aug 04 17:05:25 2015 +0900
description:
Bug 1188442 IMMHandler::GetSelection() should use static Selection instance when IME doesn't have focus and return its or mSelection's reference r=emk

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3f700e2cebbc